Skip to content

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented May 4, 2022

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-862

Description

Merged the Detailed Progress and Delegate Progress pages.
Moved all the Edit links to the View Delegate and Course Delegate cards.
Fixed the return page logic for these Edit pages.
Sorted out breadcrumbs.
Moved the Remove from course action to be with other similar actions in DelegateProgressController.

Screenshots

View Delegate card:
image

Course Delegate card:
image

Delegate Progress:
image
image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@JBsoftwire JBsoftwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one question that's just a double-check.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number of things I've spotted. Some might just be me overlooking something.

@AlexJacksonDS AlexJacksonDS merged commit f6f2696 into master May 17, 2022
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-862-merge-delegate-progress-pages branch May 17, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants