Skip to content

Conversation

@simonbrent
Copy link
Contributor

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-927

Description

When logged in as an admin user whose CategoryId is not zero, on /TrackingSystem/Centre/Reports/EditFilters the "Choose a course filter" option is now retained when you press the "Apply filters" button


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@JBsoftwire JBsoftwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

@DanBloxham-sw
Copy link
Contributor

Received both approvals, I'll merge it as Simon is away today so we can get it tested.

@DanBloxham-sw DanBloxham-sw merged commit 2701b18 into master May 30, 2022
@DanBloxham-sw DanBloxham-sw deleted the HEEDLS-927-fix-centre-reports-course-filter branch May 30, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants