From 959a0f7068a778eeedb8f5212664f0ca947b5396 Mon Sep 17 00:00:00 2001 From: Martin Foster Date: Wed, 28 Sep 2022 10:56:27 +0100 Subject: [PATCH 1/5] Fix for incorrect page index reset on new search term. --- .../Frameworks/Developer/AddCompetencyLearningResources.cshtml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml b/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml index 4001b9ed2d..be66cde8cd 100644 --- a/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml +++ b/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml @@ -68,7 +68,7 @@ @Html.LabelFor(m => m.SearchText, "Search", new { @class = "nhsuk-u-visually-hidden", @for = "search-field" }) @Html.TextBoxFor(m => m.SearchText, new { @class = "search-box nhsuk-input", id = "search-field", name = "searchString", type = "search", placeholder = "Search", autocomplete = "off" }) - -
- @Html.DropDownListFor(c => c.CatalogueId, dropdownItems, - new - { - @class = "nhsuk-u-width-full nhsuk-select nhsuk-u-margin-bottom-4", - aria_label = "Catalogue filter", - style = "border-radius: 4px;" - }) + Search + +
+
+ @Html.DropDownListFor(c => c.CatalogueId, dropdownItems, + new + { + @class = "nhsuk-u-width-full nhsuk-select nhsuk-u-margin-bottom-4", + aria_label = "Catalogue filter", + style = "border-radius: 4px;" + }) +
- - - -
- - @Html.Hidden("SearchText", Model.SearchText) - - -@if (Model.LearningHubApiError) { + +
+ + @Html.Hidden("SearchText", Model.SearchText) + + @if (Model.LearningHubApiError) +{ This service is unavailable. Please try again later. -} else if (Model.SearchResult?.Results != null) { +} +else if (Model.SearchResult?.Results != null) +{ @Model.TotalNumResources matches for "@Model.SearchText" - @foreach (var result in Model.SearchResult.Results) { + @foreach (var result in Model.SearchResult.Results) + { } } -
@Html.Hidden("SearchText", Model.SearchText) From ef1dfc201eff6c8e0b666d4e1988f7736886210e Mon Sep 17 00:00:00 2001 From: Martin Foster Date: Wed, 28 Sep 2022 11:36:03 +0100 Subject: [PATCH 4/5] Fixed spurious merge issue. --- .../AddCompetencyLearningResources.cshtml | 180 ++++++++---------- 1 file changed, 84 insertions(+), 96 deletions(-) diff --git a/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml b/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml index 860ec6f293..2a16e16846 100644 --- a/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml +++ b/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml @@ -3,132 +3,120 @@ @{ ViewData["Title"] = "Add Competency Learning Resource"; ViewData["Application"] = "Framework Service"; - < + ViewData["HeaderPathName"] = "Framework Service"; + var dropdownItems = Model.Catalogues + .Select(c => new SelectListItem( + text: c.Name + (c.IsRestricted ? " (Restricted)" : ""), + value: c.Id.ToString(), + selected: c.Id == Model.CatalogueId) + ).ToList(); + dropdownItems.Insert(0, new SelectListItem("Any catalogue", "0", !Model.CatalogueId.HasValue)); +} - < + - < +@section NavMenuItems { + +} - < - - < - - < - - < HEAD - ======= - ViewData["HeaderPathName"] = "Framework Service"; - >>>>>>> master - var dropdownItems = Model.Catalogues - .Select(c => new SelectListItem( - text: c.Name + (c.IsRestricted ? " (Restricted)" : ""), - value: c.Id.ToString(), - selected: c.Id == Model.CatalogueId) - ).ToList(); - dropdownItems.Insert(0, new SelectListItem("Any catalogue", "0", !Model.CatalogueId.HasValue)); - } - - - - @section NavMenuItems { - - } - - @section NavBreadcrumbs { - - } - -

Add Competency Learning Resource

-
- Information: -

- @Model.NameOfCompetency

- -

Search the Learning Hub

-
-
- -
- @Html.DropDownListFor(c => c.CatalogueId, dropdownItems, + Search + +
+
+ @Html.DropDownListFor(c => c.CatalogueId, dropdownItems, new { @class = "nhsuk-u-width-full nhsuk-select nhsuk-u-margin-bottom-4", aria_label = "Catalogue filter", style = "border-radius: 4px;" }) -
- -
- - @Html.Hidden("SearchText", Model.SearchText) - - @if (Model.LearningHubApiError) - { - This service is unavailable. Please try again later. - } - else if (Model.SearchResult?.Results != null) - { - @Model.TotalNumResources matches for "@Model.SearchText" - @foreach (var result in Model.SearchResult.Results) - { - - } - } + + +
- - @Html.Hidden("SearchText", Model.SearchText) + + @Html.Hidden("SearchText", Model.SearchText) - + + @if (Model.LearningHubApiError) +{ + This service is unavailable. Please try again later. +} +else if (Model.SearchResult?.Results != null) +{ + @Model.TotalNumResources matches for "@Model.SearchText" + @foreach (var result in Model.SearchResult.Results) + { + + } +} + +
+ + @Html.Hidden("SearchText", Model.SearchText) + + From 7ea0d284958e536768451a7e08e81ad47468710c Mon Sep 17 00:00:00 2001 From: Martin Foster Date: Wed, 28 Sep 2022 12:21:54 +0100 Subject: [PATCH 5/5] Fixed iif syntax issue. --- .../Frameworks/Developer/AddCompetencyLearningResources.cshtml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml b/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml index 2a16e16846..54386f9c98 100644 --- a/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml +++ b/DigitalLearningSolutions.Web/Views/Frameworks/Developer/AddCompetencyLearningResources.cshtml @@ -69,7 +69,7 @@ @Html.LabelFor(m => m.SearchText, "Search", new { @class = "nhsuk-u-visually-hidden", @for = "search-field" }) @Html.TextBoxFor(m => m.SearchText, new { @class = "search-box nhsuk-input", id = "search-field", name = "searchString", type = "search", placeholder = "Search", autocomplete = "off" })