From 08e533dad19a81180e2a5302593b729e83b087c8 Mon Sep 17 00:00:00 2001
From: Rohit Shrivastava <Rohit.Shrivastava@hee.nhs.uk>
Date: Thu, 26 Sep 2024 16:40:37 +0100
Subject: [PATCH 1/2] TD-4774 UIChangesOnProficienciesPage

---
 .../SelfAssessmentOverview.cshtml             | 26 ++++++++++++-------
 1 file changed, 17 insertions(+), 9 deletions(-)

diff --git a/DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/SelfAssessmentOverview.cshtml b/DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/SelfAssessmentOverview.cshtml
index f6f7c08a13..6c380518eb 100644
--- a/DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/SelfAssessmentOverview.cshtml
+++ b/DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/SelfAssessmentOverview.cshtml
@@ -41,7 +41,7 @@
 }
 
 @section mobilebacklink
-{
+    {
     <p class="nhsuk-breadcrumb__back">
         <a class="nhsuk-breadcrumb__backlink" asp-action="SelfAssessment"
            asp-route-selfAssessmentId="@Model.SelfAssessment.Id">
@@ -64,10 +64,25 @@
                          view-data="@(new ViewDataDictionary(ViewData) { { "IsSupervisorResultsReviewed", Model.SelfAssessment.IsSupervisorResultsReviewed } })" />
             </div>
         }
+        <partial name="_OverviewActionButtons.cshtml" model=Model />
+        @if (competencyQuestionsSummary == competencyVerifiedSummary)
+        {
+            <div class="nhsuk-warning-callout">
+                <h3 class="nhsuk-warning-callout__label">
+                    <span role="text">
+                        <span class="nhsuk-u-visually-hidden">Important: </span>
+                        You need to add optional @(Model.VocabPlural().ToLower())
+                    </span>
+                </h3>
+                <p>
+                    Your self assessment does not contain enough optional @(Model.VocabPlural().ToLower()) to request sign off.
+                    Go to Manage optional @(Model.VocabPlural().ToLower()) to choose the optional @(Model.VocabPlural().ToLower()) that you wish to include.
+                </p>
+            </div>
+        }
         <partial name="SelfAssessments/_SearchSelfAssessmentOverview"
                  model="@Model.SearchViewModel"
                  view-data="@(new ViewDataDictionary(ViewData) { { "parent", Model } })" />
-        <partial name="_OverviewActionButtons.cshtml" model=Model />
         <p><span role="alert">@Model.CompetencyGroups.Sum(g => g.Count()) matching @Model.VocabPlural().ToLower()</span></p>
         @if (Model.CompetencyGroups.Any())
         {
@@ -200,13 +215,6 @@
                         All required @Model.SelfAssessment.Vocabulary.ToLower() self-assessments must be completed and confirmed,
                         before requesting @Model.SelfAssessment.SignOffRoleName sign off of the @Model.SelfAssessment.Name.
                     </p>
-                    @if (competencyQuestionsSummary == competencyVerifiedSummary)
-                     {
-                    <p class="nhsuk-body-l">
-                        Your self assessment does not contain enough optional proficiencies to request sign off.
-                        Go to Manage Optional Competencies to choose the optional competencies that you wish to include..
-                    </p>
-                     }
                 }
             </div>
         }

From 698473f02c0481a545ddc9c554b24a4958814fa3 Mon Sep 17 00:00:00 2001
From: Rohit Shrivastava <Rohit.Shrivastava@hee.nhs.uk>
Date: Thu, 3 Oct 2024 22:43:55 +0100
Subject: [PATCH 2/2] TD-4774 Corrected the condition

---
 .../SelfAssessments/SelfAssessmentOverview.cshtml             | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/SelfAssessmentOverview.cshtml b/DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/SelfAssessmentOverview.cshtml
index 6c380518eb..00b977a6a6 100644
--- a/DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/SelfAssessmentOverview.cshtml
+++ b/DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/SelfAssessmentOverview.cshtml
@@ -65,7 +65,7 @@
             </div>
         }
         <partial name="_OverviewActionButtons.cshtml" model=Model />
-        @if (competencyQuestionsSummary == competencyVerifiedSummary)
+        @if ((competencyQuestionsSummary == competencyVerifiedSummary) && (Model.NumberOfSelfAssessedOptionalCompetencies <= Model.SelfAssessment.MinimumOptionalCompetencies))
         {
             <div class="nhsuk-warning-callout">
                 <h3 class="nhsuk-warning-callout__label">
@@ -175,7 +175,7 @@
                 <h2>@Model.SelfAssessment.SignOffRoleName Sign-off</h2>
                 <partial name="../../Supervisor/Shared/_SupervisorSignOffSummary.cshtml" model="Model.SupervisorSignOffs"
                          view-data="@(new ViewDataDictionary(ViewData) { { "IsAllCompetencyConfirmed", competencySummaries.Sum(c => (int)c["questionsCount"]) == competencySummaries.Sum(c => (int)c["verifiedCount"]) }})" />
-                @if ((Model.AllQuestionsVerifiedOrNotRequired) && (Model.NumberOfSelfAssessedOptionalCompetencies >= Model.SelfAssessment.MinimumOptionalCompetencies))
+                @if (Model.AllQuestionsVerifiedOrNotRequired)
                 {
                     @if (!Model.SupervisorSignOffs.Any())
                     {