HEEDLS-519 - Change system notification cookie management

[DanBloxham-sw]

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-519

Description

Updated the SystemNotificationController so that the cookie set when first visiting the page (Show Later link no longer needs to be clicked, allowing the user to immediately return to the dashboard). Also deleted the cookie when no more unacknowledged notifications exist.

Screenshots

N/A

---

Developer checks

I have:

• Run the formatter and made sure there are no IDE errors.
• Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
• Updated/added documentation in Swiki and/or Readme.
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
• Scanned over my own MR to ensure everything is as expected.

[AlexJacksonDS]

I can't raise against the lines, but does this change not make the SkipNotifications action redundant?

[DanBloxham-sw]

In a most cases, SkipNotifications is pretty redundant. But if there are unacknowledged notifications, skipping will reset the expiry date. It will also set the cookie if the user visits the page when no notifications are present, in case the user definitely doesn't want to see any new notifications in the next 24 hours. But these are so minor that we could get rid of them if we think its unnecessary.

[AlexJacksonDS]

It's not doing anything that the else branch isn't doing, and I assume the only page linking to the Skip action is the notification page which will have literally just set it in the else. I think the behaviour you've just described would be unexpected. If a user has no notification and then gets some, I think they should be forced to view them the next time.

[stellake]

One minor improvement suggestion to avoid double "if" blocks, but no need for rereview :)

[stellake]

Could this be simplified with:

if (unacknowledgedNotifications.Count > 0) {
    Response.Cookies.SetSkipSystemNotificationCookie(adminId, clockService.UtcNow);
} else if (HasCookie) {
   Response.Cookies.DeleteSkipSystemNotificationCookie();
}

// continue