Skip to content

Conversation

@ibrahimmunir14
Copy link
Contributor

JIRA link

HEEDLS-505

Description

  • Change max filesize to 5MiB
  • Use excel sheet header names in bulk upload error messages

Screenshots

N/A


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@ibrahimmunir14 ibrahimmunir14 force-pushed the HEEDLS-505-all-delegates-bulk-upload-journey--fix2 branch from 943b7bc to 17cda69 Compare September 15, 2021 09:18
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if only I made the decision to make all these names consistent the other way when I was doing it...

Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ibrahimmunir14 ibrahimmunir14 merged commit aa96b6f into master Sep 16, 2021
@stellake stellake deleted the HEEDLS-505-all-delegates-bulk-upload-journey--fix2 branch September 24, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants