Skip to content

Conversation

@livzorn
Copy link
Contributor

@livzorn livzorn commented Jan 7, 2022

JIRA link

HEEDLS-670

Description

Fixed the title on the page to say "complete by date" rather than "completion date"

Screenshots

localhost_5001_LearningPortal_Current_ActionPlan_102_CompleteBy


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@AlexJacksonDS AlexJacksonDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume the line endings are correct in the 2 accessibility tests files?

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Looks like the line endings are correct, hopefully that is all that was changed in those files along with the titles?

@livzorn
Copy link
Contributor Author

livzorn commented Jan 12, 2022

Yep changed those accessibility tests to CRLF. Only content difference was adjusting the titles

@livzorn livzorn merged commit fd75ca0 into master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants