Skip to content

Conversation

@wilkinsm
Copy link
Contributor

@wilkinsm wilkinsm commented Feb 7, 2022

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-564

Description

  • Set the "Active Status" filter to on and "true" by default
  • Add sort by Delegate ID to the sorting options.

Screenshots

image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty much perfect.

Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, just a suggested name change.

Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, feel free to merge.

@wilkinsm wilkinsm merged commit ace33a1 into master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants