DLSV2-518 Add overall progress summary on SelfAssessmentOverview #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentOverview.cshtml
kevwhitt-hee
reviewed
Mar 9, 2022
| </span> | ||
| <br /> | ||
| @if (selfAssessment.IsSupervisorResultsReviewed) | ||
| @if (isSupervisorResultsReviewed) |
There was a problem hiding this comment.
This needs applying to the overall summary. Currently, the confirmed summary is always shown (this is a self assessment where isSupervisorResultsReviewed == false):
kevwhitt-hee
reviewed
Mar 9, 2022
| <h2>Overall Progress</h2> | ||
| <p class="nhsuk-body-l"> | ||
| <span class="score">Self assessed: @selfAssessedTotal / @questionsTotal</span> | ||
| <span class="score">Confirmed: @verifiedTotal / @questionsTotal</span> |
There was a problem hiding this comment.
isSupervisorResultsReviewed check needs to be added here
kevwhitt-hee
approved these changes
Mar 21, 2022
kevwhitt-hee
deleted the
Develop/Features/DLSV2-518-AddOverallProgressToSelfAssessmentOverview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add overall progress summary to Sign-off area on SelfAssessmentOverview.cshtml.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-518
Description
Created total counters for self-assessed and confirmed (verified) questions in SelfAssessmentOverview.cshtml. Passing partial counts to _CompetencySummary.cshml by means of a
ViewDataDictionary.Screenshots
Developer checks
Checked that totals match the addition of all cards for self assessed and confirmed questions.