From ccbdc1d1302afc290efd0cfb5ea74bbe05e93f82 Mon Sep 17 00:00:00 2001 From: Dalin Akrasi Date: Tue, 30 Jan 2024 17:59:28 +0000 Subject: [PATCH 01/81] Fix accessibility issues in My Bookmarks section --- LearningHub.Nhs.WebUI/Styles/nhsuk/layout.scss | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/LearningHub.Nhs.WebUI/Styles/nhsuk/layout.scss b/LearningHub.Nhs.WebUI/Styles/nhsuk/layout.scss index e3a0752a0..a3fb2a56f 100644 --- a/LearningHub.Nhs.WebUI/Styles/nhsuk/layout.scss +++ b/LearningHub.Nhs.WebUI/Styles/nhsuk/layout.scss @@ -101,6 +101,16 @@ width: px2rem(260); } +.nhsuk-header__search { + .nhsuk-search__input { + width: px2rem(260); + } + + #search > label.nhsuk-u-visually-hidden { + background-color: $nhsuk-white; + } +} + .nhsuk-account__login--link, .nhsuk-account__login--link:visited, .nhsuk-account__login--link:hover { @@ -318,6 +328,10 @@ .nhsuk-back-link { padding: 0.5rem 0; } + + .nhsuk-header__menu .nhsuk-header__not-mobile { + display: none; + } } /* mobile */ From ca92c66c7b679d80a0d2fedcb207849ce78b6e66 Mon Sep 17 00:00:00 2001 From: Dalin Akrasi Date: Tue, 30 Jan 2024 18:55:33 +0000 Subject: [PATCH 02/81] Correct autocomplete references in alignment to HTML best practices --- .../Views/Account/CreateAccountPersonalDetails.cshtml | 2 +- LearningHub.Nhs.WebUI/Views/MyAccount/ChangeFirstname.cshtml | 2 +- LearningHub.Nhs.WebUI/Views/MyAccount/ChangeLastName.cshtml | 2 +- .../Views/MyAccount/ChangePreferredName.cshtml | 2 +- LearningHub.Nhs.WebUI/Views/MyAccount/ChangePrimaryEmail.cshtml | 2 +- .../Views/MyAccount/ChangeSecondaryEmail.cshtml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/LearningHub.Nhs.WebUI/Views/Account/CreateAccountPersonalDetails.cshtml b/LearningHub.Nhs.WebUI/Views/Account/CreateAccountPersonalDetails.cshtml index f41ee8cec..0e289eb4e 100644 --- a/LearningHub.Nhs.WebUI/Views/Account/CreateAccountPersonalDetails.cshtml +++ b/LearningHub.Nhs.WebUI/Views/Account/CreateAccountPersonalDetails.cshtml @@ -80,7 +80,7 @@ type="text" spell-check="false" hint-text="" - autocomplete="SecondaryEmailAddress" + autocomplete="email" css-class="nhsuk-u-width-one-half" required="false" /> diff --git a/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeFirstname.cshtml b/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeFirstname.cshtml index df034473c..5e966bebb 100644 --- a/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeFirstname.cshtml +++ b/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeFirstname.cshtml @@ -26,7 +26,7 @@ type="text" spell-check="false" hint-text="" - autocomplete="FirstName" + autocomplete="given-name" css-class="nhsuk-u-width-one-half " required="true" required-client-side-error-message="Enter a first name" /> diff --git a/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeLastName.cshtml b/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeLastName.cshtml index 242ff6a2f..6cf380170 100644 --- a/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeLastName.cshtml +++ b/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeLastName.cshtml @@ -25,7 +25,7 @@ type="text" spell-check="false" hint-text="" - autocomplete="LastName" + autocomplete="family-name" css-class="nhsuk-u-width-one-half" required="true" required-client-side-error-message="Enter a last name" /> diff --git a/LearningHub.Nhs.WebUI/Views/MyAccount/ChangePreferredName.cshtml b/LearningHub.Nhs.WebUI/Views/MyAccount/ChangePreferredName.cshtml index f4e38a767..d7106bd02 100644 --- a/LearningHub.Nhs.WebUI/Views/MyAccount/ChangePreferredName.cshtml +++ b/LearningHub.Nhs.WebUI/Views/MyAccount/ChangePreferredName.cshtml @@ -24,7 +24,7 @@ type="text" spell-check="false" hint-text="" - autocomplete="PreferredName" + autocomplete="nickname" css-class="nhsuk-u-width-one-half" required="false" /> diff --git a/LearningHub.Nhs.WebUI/Views/MyAccount/ChangePrimaryEmail.cshtml b/LearningHub.Nhs.WebUI/Views/MyAccount/ChangePrimaryEmail.cshtml index df41f9844..5f84662e6 100644 --- a/LearningHub.Nhs.WebUI/Views/MyAccount/ChangePrimaryEmail.cshtml +++ b/LearningHub.Nhs.WebUI/Views/MyAccount/ChangePrimaryEmail.cshtml @@ -32,7 +32,7 @@ type="text" spell-check="false" hint-text="" - autocomplete="PrimaryEmailAddress" + autocomplete="email" css-class="nhsuk-u-width-one-half" required="true" /> diff --git a/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeSecondaryEmail.cshtml b/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeSecondaryEmail.cshtml index 63709465e..69b92fb04 100644 --- a/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeSecondaryEmail.cshtml +++ b/LearningHub.Nhs.WebUI/Views/MyAccount/ChangeSecondaryEmail.cshtml @@ -32,7 +32,7 @@ type="text" spell-check="false" hint-text="" - autocomplete="SecondaryEmailAddress" + autocomplete="email" css-class="nhsuk-u-width-one-half" required="false" /> From c8f5509f2bc6b6ad57306a21925fc0c2cc69278a Mon Sep 17 00:00:00 2001 From: Dalin Akrasi Date: Mon, 5 Feb 2024 15:24:38 +0000 Subject: [PATCH 03/81] Fix learner search page and search results accessibility issues --- .../Views/Search/_ResourceSearchResult.cshtml | 2 +- LearningHub.Nhs.WebUI/Views/Search/_SubmitFeedback.cshtml | 1 + LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/LearningHub.Nhs.WebUI/Views/Search/_ResourceSearchResult.cshtml b/LearningHub.Nhs.WebUI/Views/Search/_ResourceSearchResult.cshtml index 07c2caa6e..6e0f806bd 100644 --- a/LearningHub.Nhs.WebUI/Views/Search/_ResourceSearchResult.cshtml +++ b/LearningHub.Nhs.WebUI/Views/Search/_ResourceSearchResult.cshtml @@ -82,7 +82,7 @@
@if (!string.IsNullOrWhiteSpace(item.CatalogueBadgeUrl) && showCatalogueFieldsInResources) { - + Resource catalog badge } @if (!string.IsNullOrEmpty(item.CatalogueName) && !this.Model.CatalogueId.HasValue && showCatalogueFieldsInResources) diff --git a/LearningHub.Nhs.WebUI/Views/Search/_SubmitFeedback.cshtml b/LearningHub.Nhs.WebUI/Views/Search/_SubmitFeedback.cshtml index 6d220e4f1..dca9f2bce 100644 --- a/LearningHub.Nhs.WebUI/Views/Search/_SubmitFeedback.cshtml +++ b/LearningHub.Nhs.WebUI/Views/Search/_SubmitFeedback.cshtml @@ -34,6 +34,7 @@ +
diff --git a/LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml b/LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml index 929dc8f1a..0a9862213 100644 --- a/LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml +++ b/LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml @@ -26,7 +26,7 @@ @await Component.InvokeAsync("NavigationItems", new { navView = "MobileTopRightNav", controllerName = controllerName }) @if (User.Identity.IsAuthenticated) {
- + @await Component.InvokeAsync("NavigationItems", new { navView = "MenuNotificationDot" })
} @@ -40,7 +40,7 @@ @if (User.Identity.IsAuthenticated) {
- + @await Component.InvokeAsync("NavigationItems", new { navView = "MenuNotificationDot" })
} From 3433b217c8bf7eca4b2c260c2e9feb2aa74c9453 Mon Sep 17 00:00:00 2001 From: Dalin Akrasi Date: Mon, 12 Feb 2024 08:41:32 +0000 Subject: [PATCH 04/81] Fix learner catalogue pages accessibility issues --- LearningHub.Nhs.WebUI/Views/Catalogue/Index.cshtml | 5 +++-- LearningHub.Nhs.WebUI/Views/Home/_CatalogueTray.cshtml | 4 ++-- .../Views/Home/_MyAccessedLearningTray.cshtml | 4 ++-- LearningHub.Nhs.WebUI/Views/Home/_ResourceTray.cshtml | 4 ++-- LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml | 6 +++--- 5 files changed, 12 insertions(+), 11 deletions(-) diff --git a/LearningHub.Nhs.WebUI/Views/Catalogue/Index.cshtml b/LearningHub.Nhs.WebUI/Views/Catalogue/Index.cshtml index 8086ac508..dc9e938e4 100644 --- a/LearningHub.Nhs.WebUI/Views/Catalogue/Index.cshtml +++ b/LearningHub.Nhs.WebUI/Views/Catalogue/Index.cshtml @@ -163,12 +163,13 @@ @* Tab header *@