From c8f5509f2bc6b6ad57306a21925fc0c2cc69278a Mon Sep 17 00:00:00 2001
From: Dalin Akrasi <Dalin.Akrasi@hee.nhs.uk>
Date: Mon, 5 Feb 2024 15:24:38 +0000
Subject: [PATCH] Fix learner search page and search results accessibility
 issues

---
 .../Views/Search/_ResourceSearchResult.cshtml                 | 2 +-
 LearningHub.Nhs.WebUI/Views/Search/_SubmitFeedback.cshtml     | 1 +
 LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml         | 4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/LearningHub.Nhs.WebUI/Views/Search/_ResourceSearchResult.cshtml b/LearningHub.Nhs.WebUI/Views/Search/_ResourceSearchResult.cshtml
index 07c2caa6e..6e0f806bd 100644
--- a/LearningHub.Nhs.WebUI/Views/Search/_ResourceSearchResult.cshtml
+++ b/LearningHub.Nhs.WebUI/Views/Search/_ResourceSearchResult.cshtml
@@ -82,7 +82,7 @@
     <div class="resource-author">
       @if (!string.IsNullOrWhiteSpace(item.CatalogueBadgeUrl) && showCatalogueFieldsInResources)
       {
-        <img class="resource-catalogue-badge" src="/search/image/@item.CatalogueBadgeUrl" />
+        <img class="resource-catalogue-badge" src="/search/image/@item.CatalogueBadgeUrl" alt="Resource catalog badge"/>
       }
 
       @if (!string.IsNullOrEmpty(item.CatalogueName) && !this.Model.CatalogueId.HasValue && showCatalogueFieldsInResources)
diff --git a/LearningHub.Nhs.WebUI/Views/Search/_SubmitFeedback.cshtml b/LearningHub.Nhs.WebUI/Views/Search/_SubmitFeedback.cshtml
index 6d220e4f1..dca9f2bce 100644
--- a/LearningHub.Nhs.WebUI/Views/Search/_SubmitFeedback.cshtml
+++ b/LearningHub.Nhs.WebUI/Views/Search/_SubmitFeedback.cshtml
@@ -34,6 +34,7 @@
                 <input type="hidden" name="groupId" value="@Model.GroupId" />
                 <input type="hidden" name="resourceCount" value="@Model.ResourceSearchResult?.TotalHits" />
 
+                <label class="nhsuk-u-visually-hidden" for="Feedback">Feedback</label>
                 <textarea maxlength="1000" name="Feedback" id="Feedback" class="nhsuk-textarea @(this.ViewBag.EmptyFeedbackError == true ? "nhsuk-textarea--error" : "")" rows="5" aria-describedby="feedback-hint"></textarea>
             </div>
 
diff --git a/LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml b/LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml
index 929dc8f1a..0a9862213 100644
--- a/LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml
+++ b/LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml
@@ -26,7 +26,7 @@
       @await Component.InvokeAsync("NavigationItems", new { navView = "MobileTopRightNav", controllerName = controllerName })
       @if (User.Identity.IsAuthenticated) {
         <div class="nhsuk-header__menu">
-          <label for="header-dropdown-menu-control" class="nhsuk-header__menu-toggle" id="toggle-menu" aria-controls="header-navigation" aria-expanded="false">Menu</label>
+          <label class="nhsuk-header__menu-toggle" id="toggle-menu" aria-controls="header-navigation" aria-expanded="false">Menu</label>
           @await Component.InvokeAsync("NavigationItems", new { navView = "MenuNotificationDot" })
         </div>
       }
@@ -40,7 +40,7 @@
 
   @if (User.Identity.IsAuthenticated) {
     <div class="nhsuk-header__menu nhsuk-header__not-mobile">
-      <label for="header-dropdown-menu-control" class="nhsuk-header__menu-toggle" id="toggle-menu" aria-controls="header-navigation" aria-expanded="false">Menu</label>
+      <label class="nhsuk-header__menu-toggle" id="toggle-menu" aria-controls="header-navigation" aria-expanded="false">Menu</label>
       @await Component.InvokeAsync("NavigationItems", new { navView = "MenuNotificationDot" })
     </div>
   }