Skip to content

Refactor logging #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 18, 2025
Merged

Refactor logging #100

merged 5 commits into from
Aug 18, 2025

Conversation

@Phil-NHS
Copy link
Collaborator

@Phil-NHS Phil-NHS commented Aug 18, 2025

PR Template

JIRA/RoadMap

_Provide your ticket number
TD-####
Git Ticket BoardTicket Board
Git Ticket

Description

Describe what has changed and how that will affect the app. If relevant, add links to any sources/documentation you used. Highlight anything unusual and give people context around particular decisions.

Resulting Dev package

_Your dev generated package name and reference
TELBlazor published packages
Dev packages are follow by branch name -branch-name and are generated
Will this code change result in a production package version increase

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.

Linked package consumer tasks

TD-####
[ ] - consumers also need to update nhsuk css dependency to : put_required_nhsuk_semantic_version_here

Logging

_Provide description of any component scoped logging or specific level logging to check

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Provided showcase example of component if applicable
  • Added appropriate logging and scopped logging reporting in appsettings for component if applicable
  • Updated readme documentation
  • Updated showcase documentation for component
  • I have locally run tests against a local package (not just using project reference)
  • Used a browser set to No Js before using it to locally run and test changes (recommend brave as second browser)
  • Written Unit tests with accesibility syntax
  • Written E2E tests with accesibility syntax and accessibility test
  • Tested components with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Check code coverage or locally with local report generation
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the PR and need to be tested to ensure nothing is broken
  • Tested in Dev Showcase (including logging by using log level switcher)
  • Scanned over my pull request and commented with any useful explanations/questions to reviewers
  • Scanned over cicd warnings

Peer Reviewers and Assignee checks before Approval

  • Feedback has been provided
  • Project has been run locally (you can provide pr feedback via vs if desired)
  • Locally checked in browser set to No Js from before load (recommend Brave with no js settings)
  • Dev Showcase was checked and it was checked the package number matched the PR
  • In Dev Showcase checked against different logging levels if applicable (use log level switcher to change level)
  • All conversations have been responded to (emoji will do) and marked resolved
  • Out of scope code observations have been recorded to inform future tasks
  • Common questions / Architectural explanations decisions from PR documented
  • Check code coverage
  • Should E2E or Unit test have been added
  • If the published dev package is linked and used in tandom with a package consumer task is it working locally (Not a hard requirement but useful in case changes required)
  • Checked component readme in Showcase

Post PR Intentions and Actions

  • On merge will someone check Prod Showcase
  • Tick yes if consuming projects need a version bump and/or code changes to take advantage of new components etc
  • If there is a linked consuming project task has the task assignee, or task been updated to know the package is available as a dev/prod version and been provided the version number.

Phil-NHS and others added 5 commits August 18, 2025 15:53
@Phil-NHS
feat(cicd): pipeline errors in sematinc versioning
893d755
@Phil-NHS
Merge branch 'refactor-logging' of https://github.com/TechnologyEnhan…
c730fa4 
…cedLearning/TELBlazor into refactor-logging
@semantic-release-bot
chore(release): 1.11.0-refactor-logging.1 [skip ci]
ff5f6a2 
# [1.11.0-refactor-logging.1](v1.10.0...v1.11.0-refactor-logging.1) (2025-08-18)

### Features

* **cicd:** pipeline errors in sematinc versioning ([893d755](893d755))
* **cicd:** Tidy and version increment check ([77dbf5d](77dbf5d))
@Phil-NHS
Merge branch 'master' into refactor-logging
58cb703
@semantic-release-bot
chore(release): 1.12.0-refactor-logging.1 [skip ci]
5737e23 
# [1.12.0-refactor-logging.1](v1.11.0...v1.12.0-refactor-logging.1) (2025-08-18)

### Features

* **cicd:** pipeline errors in sematinc versioning ([893d755](893d755))
@kevwhitt-hee
Copy link
Contributor

kevwhitt-hee commented Aug 18, 2025

🎉 This PR is included in version 1.12.0-refactor-logging.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Phil-NHS Phil-NHS merged commit dbaf915 into master Aug 18, 2025
1 check passed
@kevwhitt-hee
Copy link
Contributor

kevwhitt-hee commented Aug 18, 2025

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released on @refactor-logging released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Phil-NHS @kevwhitt-hee @semantic-release-bot