Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official CSS spec from w3c #3

Open
wants to merge 2 commits into
base: master
from

Conversation

@lukejagodzinski
Copy link

lukejagodzinski commented Jan 2, 2020

After investigating it more, I've noticed that as the DOM version would work in the browser and could theoretically be polyfilled in node, it wouldn't be the best experience. The polyfill would produce different result. I've checked how the jsdom code is implemented and it's using the cssstyle package which takes list of the css properties from the official w3c spec, which can be found here in the JSON format: https://www.w3.org/Style/CSS/all-properties.en.json

So instead of using DOM version, I've just updated code to make use of the official spec which should always be up to date. The cli tool, could also take an argument that would filter css properties by status (Release Candidate, Working Draft etc.). Right now, this PR returns all the CSS properties experimental and shipped in browsers.

@TejasQ
TejasQ approved these changes Jan 2, 2020
Copy link
Owner

TejasQ left a comment

You’re amazing!

@TejasQ

This comment has been minimized.

Copy link
Owner

TejasQ commented Jan 11, 2020

@lukejagodzinski mind resolving the conflicts so we can merge this?

@lukejagodzinski

This comment has been minimized.

Copy link
Author

lukejagodzinski commented Jan 15, 2020

Sure I will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.