Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "noreferrer noopener" rel attributes for external links #10

Closed
jormee opened this issue Nov 18, 2019 · 5 comments
Closed

Set "noreferrer noopener" rel attributes for external links #10

jormee opened this issue Nov 18, 2019 · 5 comments

Comments

@jormee
Copy link
Contributor

jormee commented Nov 18, 2019

Hi @TejasQ,
adding a rel="noreferrer noopener" attribute to links to external pages helps improve performance and prevents vulnerabilities.

/tejaskumar_(twitter.com) | _blank 
/tejasq(github.com) | _blank |  
/TejasQ/tejaskumar.com(github.com) | _blank |  
@TejasQ
Copy link
Owner

TejasQ commented Nov 19, 2019

Hi jormee! Thanks for this! Can you tell me how exactly this attribute helps improve performance and prevents vulnerabilities?

@jormee
Copy link
Contributor Author

jormee commented Nov 19, 2019

Hi Tejas,
When you link to an external site using the target="blank" attribute without the rel="noopener" attribute, the new tab/window exposes the window object of the current window. see this post for more information.
Also, this google dev post talks about the performance effect.

Kind regards

@TejasQ
Copy link
Owner

TejasQ commented Nov 19, 2019

That's amazing! Thank you so much! Would you like to open a PR that fixes this?

@jormee
Copy link
Contributor Author

jormee commented Nov 19, 2019

Sure, I would love to

@TejasQ
Copy link
Owner

TejasQ commented Jan 15, 2020

Thanks for the PR!

@TejasQ TejasQ closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants