Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tejamaican PR #12

Open
wants to merge 1 commit into
base: master
from
Open

Tejamaican PR #12

wants to merge 1 commit into from

Conversation

@dalevross
Copy link

dalevross commented Jan 1, 2020

First draft of modifications.

  • I assume the attributions could be properly typed such that only integer indices and string attributions are allowed but I'm not quite there yet.
  • I assume the package-lock.json should generally be committed but that's a vague recollection of something I read setting up my first npm project a few weeks ago.
  • The image could be cleaner and I'm hoping to sharpen my graphic skills in 2020.
…erly typed such that only integer indices and string attributions are allowed but I'm not quite there yet. I assume the package-lock.json should generally be committed but that's a vague recollection of something I read setting up my first npm project a few weeks ago. Image could be cleaner and I'm hoping to sharpen my graphic skills in 2020.
@now

This comment has been minimized.

Copy link

now bot commented Jan 1, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/tejask/tejaskumarcom/cnrbmwgs0
Preview: https://tejaskumarcom-git-fork-dalevross-master.tejask.now.sh

Copy link
Owner

TejasQ left a comment

Thank you for your amazing pull request, @dalevross! 🎉

Let's make a few changes (see below) and remove the package-lock.json file and then we should be good to go. 🚀

@@ -0,0 +1,3 @@
export default {

This comment has been minimized.

Copy link
@TejasQ

TejasQ Jan 13, 2020

Owner

We don't need this file or this attribution because it's creative commons, meaning we can use it without attribution AFAIK.

This comment has been minimized.

Copy link
@dalevross

dalevross Jan 13, 2020

Author

Aye, Aye. How are you doing today?

pages/index.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.