Fix incorrect documentation of offset loss unit for Open/Short/Load Standards #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of
offsetLoss
inOpenStandard
,ShortStandard
andLoadStandard
appears incorrect. It reads:However, all of these classes actually pass the
offsetLoss
unchanged into theOffset
class.And the
Offset
class actually interpretsoffsetLoss
in ohms/s, not Gohms/s.Due to this typo, I've wasted hours trying to solve my incorrect calculations in SignalIntegrity, it was because
offsetLoss
didn't do anything - it was too small by 9 orders of magnitude.This patch fixes the documentation.