From a1f56b78ce939f083018302ddc884d9b33a35251 Mon Sep 17 00:00:00 2001 From: CyrilFerlicot Date: Fri, 28 Jun 2019 19:25:00 +0200 Subject: [PATCH 1/2] TestCase do not end with s. Fixes #19 --- ...Tests.class.st => TLCysShapeTest.class.st} | 8 ++++---- ...s.st => TLCytoscapeConnectorTest.class.st} | 14 ++++++------- ...ass.st => TLVirtualStructureTest.class.st} | 20 +++++++++---------- ...st => TLVisualizationCommandTest.class.st} | 6 +++--- 4 files changed, 24 insertions(+), 24 deletions(-) rename src/Telescope-Cytoscape-Tests/{TLCysShapeTests.class.st => TLCysShapeTest.class.st} (78%) rename src/Telescope-Cytoscape-Tests/{TLCytoscapeConnectorTests.class.st => TLCytoscapeConnectorTest.class.st} (87%) rename src/Telescope-Cytoscape-Tests/{TLVirtualStructureTests.class.st => TLVirtualStructureTest.class.st} (88%) rename src/Telescope-Cytoscape-Tests/{TLVisualizationCommandTests.class.st => TLVisualizationCommandTest.class.st} (75%) diff --git a/src/Telescope-Cytoscape-Tests/TLCysShapeTests.class.st b/src/Telescope-Cytoscape-Tests/TLCysShapeTest.class.st similarity index 78% rename from src/Telescope-Cytoscape-Tests/TLCysShapeTests.class.st rename to src/Telescope-Cytoscape-Tests/TLCysShapeTest.class.st index 2c5e5da6..0cc6bab2 100644 --- a/src/Telescope-Cytoscape-Tests/TLCysShapeTests.class.st +++ b/src/Telescope-Cytoscape-Tests/TLCysShapeTest.class.st @@ -1,16 +1,16 @@ Class { - #name : #TLCysShapeTests, + #name : #TLCysShapeTest, #superclass : #TestCase, - #category : 'Telescope-Cytoscape-Tests-Shape' + #category : #'Telescope-Cytoscape-Tests-Shape' } { #category : #helpers } -TLCysShapeTests >> actualClass [ +TLCysShapeTest >> actualClass [ ^ TLSimpleShape ] { #category : #tests } -TLCysShapeTests >> testCytoscapePolygonPointsFrom [ +TLCysShapeTest >> testCytoscapePolygonPointsFrom [ self assert: (self actualClass diff --git a/src/Telescope-Cytoscape-Tests/TLCytoscapeConnectorTests.class.st b/src/Telescope-Cytoscape-Tests/TLCytoscapeConnectorTest.class.st similarity index 87% rename from src/Telescope-Cytoscape-Tests/TLCytoscapeConnectorTests.class.st rename to src/Telescope-Cytoscape-Tests/TLCytoscapeConnectorTest.class.st index 0d632961..ece67773 100644 --- a/src/Telescope-Cytoscape-Tests/TLCytoscapeConnectorTests.class.st +++ b/src/Telescope-Cytoscape-Tests/TLCytoscapeConnectorTest.class.st @@ -1,19 +1,19 @@ Class { - #name : #TLCytoscapeConnectorTests, + #name : #TLCytoscapeConnectorTest, #superclass : #BabyMock2TestCase, #instVars : [ 'connector' ], - #category : 'Telescope-Cytoscape-Tests-Connector' + #category : #'Telescope-Cytoscape-Tests-Connector' } { #category : #initialization } -TLCytoscapeConnectorTests >> setUp [ +TLCytoscapeConnectorTest >> setUp [ connector := TLCytoscapeConnector new ] { #category : #'as yet unclassified' } -TLCytoscapeConnectorTests >> testGroupUpdating [ +TLCytoscapeConnectorTest >> testGroupUpdating [ | group | group := TLEntitiesGroup new. group @@ -31,7 +31,7 @@ TLCytoscapeConnectorTests >> testGroupUpdating [ ] { #category : #'as yet unclassified' } -TLCytoscapeConnectorTests >> testGroupUpdatingAfterMoving [ +TLCytoscapeConnectorTest >> testGroupUpdatingAfterMoving [ | groupA groupB node | groupA := TLEntitiesGroup new. groupA @@ -54,7 +54,7 @@ TLCytoscapeConnectorTests >> testGroupUpdatingAfterMoving [ ] { #category : #'as yet unclassified' } -TLCytoscapeConnectorTests >> testLayoutApplicationOnComposite [ +TLCytoscapeConnectorTest >> testLayoutApplicationOnComposite [ | group mockLayout | group := TLEntitiesGroup new. mockLayout := protocol mock: 'layout'. @@ -68,7 +68,7 @@ TLCytoscapeConnectorTests >> testLayoutApplicationOnComposite [ ] { #category : #'as yet unclassified' } -TLCytoscapeConnectorTests >> testLayoutApplicationOnCompositeIntoComposite [ +TLCytoscapeConnectorTest >> testLayoutApplicationOnCompositeIntoComposite [ | group mockLayout childrenMockLayout | group := TLEntitiesGroup new. mockLayout := protocol mock: 'layout'. diff --git a/src/Telescope-Cytoscape-Tests/TLVirtualStructureTests.class.st b/src/Telescope-Cytoscape-Tests/TLVirtualStructureTest.class.st similarity index 88% rename from src/Telescope-Cytoscape-Tests/TLVirtualStructureTests.class.st rename to src/Telescope-Cytoscape-Tests/TLVirtualStructureTest.class.st index d6244131..b7edba97 100644 --- a/src/Telescope-Cytoscape-Tests/TLVirtualStructureTests.class.st +++ b/src/Telescope-Cytoscape-Tests/TLVirtualStructureTest.class.st @@ -1,11 +1,11 @@ Class { - #name : #TLVirtualStructureTests, + #name : #TLVirtualStructureTest, #superclass : #TestCase, - #category : 'Telescope-Cytoscape-Tests-Virtual' + #category : #'Telescope-Cytoscape-Tests-Virtual' } { #category : #tests } -TLVirtualStructureTests >> testLayoutApplication [ +TLVirtualStructureTest >> testLayoutApplication [ | nodes | nodes := (1 to: 10) collect: [ :i | TLVirtualNode new dimension: 5@8 ]. TLLinearLayout topToBottom on: nodes. @@ -13,7 +13,7 @@ TLVirtualStructureTests >> testLayoutApplication [ ] { #category : #tests } -TLVirtualStructureTests >> testNodeInCompositeInCompositePosition [ +TLVirtualStructureTest >> testNodeInCompositeInCompositePosition [ "Cyril: I think this test is wrong but I am not sure so I tag this test as expected failure for the release and we can patch this later with Guillaume." @@ -37,7 +37,7 @@ TLVirtualStructureTests >> testNodeInCompositeInCompositePosition [ ] { #category : #tests } -TLVirtualStructureTests >> testNodeInCompositePosition [ +TLVirtualStructureTest >> testNodeInCompositePosition [ "Cyril: I think this test is wrong but I am not sure so I tag this test as expected failure for the release and we can patch this later with Guillaume." @@ -56,7 +56,7 @@ TLVirtualStructureTests >> testNodeInCompositePosition [ ] { #category : #tests } -TLVirtualStructureTests >> testNodeWithDimension [ +TLVirtualStructureTest >> testNodeWithDimension [ | node | node := TLVirtualNode new dimension: 6 @ 10. node position: 42 @ 47. @@ -66,7 +66,7 @@ TLVirtualStructureTests >> testNodeWithDimension [ ] { #category : #tests } -TLVirtualStructureTests >> testNodesInGroupInGroup [ +TLVirtualStructureTest >> testNodesInGroupInGroup [ "Cyril: I think this test is wrong but I am not sure so I tag this test as expected failure for the release and we can patch this later with Guillaume." @@ -85,7 +85,7 @@ TLVirtualStructureTests >> testNodesInGroupInGroup [ ] { #category : #tests } -TLVirtualStructureTests >> testRemoveNodeFromAGroupThenAddToAnotherWithAdd [ +TLVirtualStructureTest >> testRemoveNodeFromAGroupThenAddToAnotherWithAdd [ |groupSource groupTarget node| node:= TLVirtualNode new. groupSource := TLVirtualGroup new. @@ -105,7 +105,7 @@ TLVirtualStructureTests >> testRemoveNodeFromAGroupThenAddToAnotherWithAdd [ ] { #category : #tests } -TLVirtualStructureTests >> testRemoveNodeFromAGroupThenAddToAnotherWithParentSelector [ +TLVirtualStructureTest >> testRemoveNodeFromAGroupThenAddToAnotherWithParentSelector [ |groupSource groupTarget node| node:= TLVirtualNode new. groupSource := TLVirtualGroup new. @@ -125,7 +125,7 @@ TLVirtualStructureTests >> testRemoveNodeFromAGroupThenAddToAnotherWithParentSel ] { #category : #tests } -TLVirtualStructureTests >> testTwoNodesInCompositePosition [ +TLVirtualStructureTest >> testTwoNodesInCompositePosition [ | parent child1 child2 | parent := TLVirtualNode new dimension: 50 @ 40. parent compositeMargin: 0@0. diff --git a/src/Telescope-Cytoscape-Tests/TLVisualizationCommandTests.class.st b/src/Telescope-Cytoscape-Tests/TLVisualizationCommandTest.class.st similarity index 75% rename from src/Telescope-Cytoscape-Tests/TLVisualizationCommandTests.class.st rename to src/Telescope-Cytoscape-Tests/TLVisualizationCommandTest.class.st index ca53c0b1..5dede086 100644 --- a/src/Telescope-Cytoscape-Tests/TLVisualizationCommandTests.class.st +++ b/src/Telescope-Cytoscape-Tests/TLVisualizationCommandTest.class.st @@ -1,11 +1,11 @@ Class { - #name : #TLVisualizationCommandTests, + #name : #TLVisualizationCommandTest, #superclass : #TestCase, - #category : 'Telescope-Cytoscape-Tests-Commands' + #category : #'Telescope-Cytoscape-Tests-Commands' } { #category : #tests } -TLVisualizationCommandTests >> testTLVisualizationAddEdgeCommand [ +TLVisualizationCommandTest >> testTLVisualizationAddEdgeCommand [ | command json | command := TLVisualizationAddEdgeCommand new edgeId: '5'; From 483985068660f8e3139601136b842a061c9d0795 Mon Sep 17 00:00:00 2001 From: CyrilFerlicot Date: Fri, 28 Jun 2019 19:44:12 +0200 Subject: [PATCH 2/2] Cleaning --- ...sShapeTest.class.st => TLCystoscapeShapeTest.class.st} | 6 +++--- .../TLCytoscapeConnectorTest.class.st | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) rename src/Telescope-Cytoscape-Tests/{TLCysShapeTest.class.st => TLCystoscapeShapeTest.class.st} (82%) diff --git a/src/Telescope-Cytoscape-Tests/TLCysShapeTest.class.st b/src/Telescope-Cytoscape-Tests/TLCystoscapeShapeTest.class.st similarity index 82% rename from src/Telescope-Cytoscape-Tests/TLCysShapeTest.class.st rename to src/Telescope-Cytoscape-Tests/TLCystoscapeShapeTest.class.st index 0cc6bab2..90617116 100644 --- a/src/Telescope-Cytoscape-Tests/TLCysShapeTest.class.st +++ b/src/Telescope-Cytoscape-Tests/TLCystoscapeShapeTest.class.st @@ -1,16 +1,16 @@ Class { - #name : #TLCysShapeTest, + #name : #TLCystoscapeShapeTest, #superclass : #TestCase, #category : #'Telescope-Cytoscape-Tests-Shape' } { #category : #helpers } -TLCysShapeTest >> actualClass [ +TLCystoscapeShapeTest >> actualClass [ ^ TLSimpleShape ] { #category : #tests } -TLCysShapeTest >> testCytoscapePolygonPointsFrom [ +TLCystoscapeShapeTest >> testCytoscapePolygonPointsFrom [ self assert: (self actualClass diff --git a/src/Telescope-Cytoscape-Tests/TLCytoscapeConnectorTest.class.st b/src/Telescope-Cytoscape-Tests/TLCytoscapeConnectorTest.class.st index ece67773..a84b0170 100644 --- a/src/Telescope-Cytoscape-Tests/TLCytoscapeConnectorTest.class.st +++ b/src/Telescope-Cytoscape-Tests/TLCytoscapeConnectorTest.class.st @@ -12,7 +12,7 @@ TLCytoscapeConnectorTest >> setUp [ connector := TLCytoscapeConnector new ] -{ #category : #'as yet unclassified' } +{ #category : #tests } TLCytoscapeConnectorTest >> testGroupUpdating [ | group | group := TLEntitiesGroup new. @@ -30,7 +30,7 @@ TLCytoscapeConnectorTest >> testGroupUpdating [ ] -{ #category : #'as yet unclassified' } +{ #category : #tests } TLCytoscapeConnectorTest >> testGroupUpdatingAfterMoving [ | groupA groupB node | groupA := TLEntitiesGroup new. @@ -53,7 +53,7 @@ TLCytoscapeConnectorTest >> testGroupUpdatingAfterMoving [ self assert: (connector elementFromTLDrawable: node) parent equals: (connector elementFromTLDrawable: groupB) ] -{ #category : #'as yet unclassified' } +{ #category : #tests } TLCytoscapeConnectorTest >> testLayoutApplicationOnComposite [ | group mockLayout | group := TLEntitiesGroup new. @@ -67,7 +67,7 @@ TLCytoscapeConnectorTest >> testLayoutApplicationOnComposite [ group generate. ] -{ #category : #'as yet unclassified' } +{ #category : #tests } TLCytoscapeConnectorTest >> testLayoutApplicationOnCompositeIntoComposite [ | group mockLayout childrenMockLayout | group := TLEntitiesGroup new.