New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support basic auth for accessing authenticated gateway #2

Closed
Templum opened this Issue Aug 7, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@Templum
Copy link
Owner

Templum commented Aug 7, 2018

In the same way functions in OpenFaaS Cloud access a secret to access the API Gateway's function list, we should enable this for the connector.

@Templum Templum added the enhancement label Aug 7, 2018

@alexellis

This comment has been minimized.

Copy link

alexellis commented Nov 18, 2018

Hi Simon, I would consider this feature essential now.

I've put together a small SDK which may be useful for you - or if that's too much work to adopt, then there's also the Kafka connector to which I added auth recently.

SDK example:
https://github.com/openfaas-incubator/connector-sdk/blob/master/cmd/tester/main.go

Alex

@Templum

This comment has been minimized.

Copy link
Owner

Templum commented Nov 18, 2018

Hi @alexellis ,

Alright, I will use the SDK then. Based on what I saw in the code, there are some parts that need modification. For now, using the SDK I can only print the responses (Invoker), but I wanted to receive the answer. So I have the option to send it to an answering queue.

Another thing is that I currently experience issues with importing github.com/openfaas-incubator/connector-sdk/types. It breaks the dep tool, as there is no main. I defined it in my toml with

[[constraint]]
  name = "github.com/openfaas-incubator/connector-sdk/types"
  version = "0.1.0"
@alexellis

This comment has been minimized.

Copy link

alexellis commented Nov 24, 2018

You should be able to vendor the types package directly without needing to access a main package. 👍

I'd consider this work high priority.

@Templum

This comment has been minimized.

Copy link
Owner

Templum commented Nov 25, 2018

Hi @alexellis ,

Thanks for your information, I still have a way to go in regards to Golang. So I was able to use the types directly as you mentioned, a local test was also successful. The only thing missing now is to update the documentation and the docker-compose & K8S files.

Best wishes,
Simon

@alexellis

This comment has been minimized.

Copy link

alexellis commented Nov 25, 2018

Hi Simon,

Glad to hear about the progress. Once ready I'd suggest doing a "Release" through the GitHub Releases page on this repo.

Please feel free to reach out for help, advise or to ask questions on our Slack community any time you need.

Alex

@Templum Templum closed this Dec 19, 2018

@Templum

This comment has been minimized.

Copy link
Owner

Templum commented Dec 20, 2018

Hello @alexellis ,

I performed the release it is now also available @ DockerHub with the tags latest, stable & 0.1.0.
It includes the necessary code for Basic Auth. Further, the documentation was updated to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment