feat(hippy-vue): rm compatible process for endReached & loadMore event

Tencent · May 27, 2022 · d320eb1 · d320eb1
1 parent 7a45c0e
commit d320eb1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 19 deletions.
diff --git a/packages/hippy-vue/src/renderer/element-node.js b/packages/hippy-vue/src/renderer/element-node.js
@@ -474,10 +474,10 @@ class ElementNode extends ViewNode {
         this.attributes.scrollEventThrottle = scrollEventThrottle;
       }
     }
-    this._emitter.addEventListener(eventNames, callback, options);
     if (typeof this.polyfillNativeEvents === 'function') {
-      this.polyfillNativeEvents('addEventListener', eventNames, callback, options);
+      ({ eventNames, callback, options } = this.polyfillNativeEvents('addEventListener', eventNames, callback, options));
     }
+    this._emitter.addEventListener(eventNames, callback, options);
     updateChild(this);
   }
 
@@ -486,7 +486,7 @@ class ElementNode extends ViewNode {
       return null;
     }
     if (typeof this.polyfillNativeEvents === 'function') {
-      this.polyfillNativeEvents('removeEventListener', eventNames, callback, options);
+      ({ eventNames, callback, options } = this.polyfillNativeEvents('removeEventListener', eventNames, callback, options));
     }
     const observer = this._emitter.removeEventListener(eventNames, callback, options);
     updateChild(this);

diff --git a/packages/hippy-vue/src/renderer/list-item-node.js b/packages/hippy-vue/src/renderer/list-item-node.js
@@ -32,10 +32,8 @@ class ListItemNode extends ElementNode {
     let name = eventNames;
     if (eventNames === 'disappear' && Native.Platform === 'android') {
       name = 'disAppear';
-      if (this.emitter && this.emitter[method]) {
-        this.emitter[method](name, callback, options);
-      }
     }
+    return { eventNames: name, callback, options };
   }
 }
 

diff --git a/packages/hippy-vue/src/renderer/list-node.js b/packages/hippy-vue/src/renderer/list-node.js
@@ -44,19 +44,6 @@ class ListNode extends ElementNode {
     }
     Native.callUIFunction(this, 'scrollToContentOffset', [posX, posY, needAnimation]);
   }
-
-  /**
-   * Polyfill native event
-   */
-  polyfillNativeEvents(method, eventNames, callback, options) {
-    let name = eventNames;
-    if (eventNames === 'loadMore') {
-      name = 'endReached';
-      if (this.emitter && this.emitter[method]) {
-        this.emitter[method](name, callback, options);
-      }
-    }
-  }
 }
 
 export default ListNode;