NaN encoded as 2.696539702293474e308

[stepelu]

I am aware that NaNs are not part of the JSON standard and I am not advocating adding the ability to encode/decode them.

However, currently NaNs are silently encoded as 2.696539702293474e308 which is very error prone.
It would be preferable to have an error thrown in Writer::Double() if a NaN is passed.

[miloyip]

Yes. This is not currently checked.

With the current bool WriteDouble(double d) API, I can make it return false if d is either NaN or infinity.

[stepelu]

Thanks for the prompt fix!

While Nans should be checked, I am unsure about the Inf case.
I am actually able to get them forth and back correctly, do you have any opinion on the matter?

[miloyip]

I don't think it is able to make a roundtrip for +/-inf.
#36 has proposed to add relaxed JSON syntax for NaN/though.
If you think #510 is OK, I will merge it.

[stepelu]

Yes, it is fine with me, thank you.

On 20 January 2016 at 12:23, Milo Yip notifications@github.com wrote:

I don't think it is able to make a roundtrip for +/-inf.
#36 #36 has proposed to add
relaxed JSON syntax for NaN/though.
If you think #510 #510 is OK,
I will merge it.

—
Reply to this email directly or view it on GitHub
#509 (comment).