New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Klocwork issues from schema.h #1083

Merged
merged 2 commits into from Oct 20, 2017

Conversation

Projects
None yet
3 participants
@piotr-kaminski-intel
Contributor

piotr-kaminski-intel commented Oct 6, 2017

Removing Klocwork static code analysis critical issues:

line 358:
'this->notValidatorIndex_' might not be initialized in this constructor.
line :412
Pointer 'schemaDocument' checked for NULL at line 412 may be passed to function and may be dereferenced there by passing argument this to function 'CreateSchema' at line 419. Also there are 7 similar errors on lines 467 479 511 523 533 538 549.

Removing Klocwork issues from schema.h
Removing Klocwork static code analysis critical issues:

line 358:
'this->notValidatorIndex_' might not be initialized in this constructor.
line :412
Pointer 'schemaDocument' checked for NULL at line 412 may be passed to function and may be dereferenced there by passing argument this to function 'CreateSchema' at line 419. Also there are 7 similar errors on lines 467 479 511 523 533 538 549.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 6, 2017

Coverage Status

Coverage decreased (-2.0e-05%) to 99.918% when pulling b217cc6 on piotr-kaminski-intel:master into 2a0bc60 on Tencent:master.

coveralls commented Oct 6, 2017

Coverage Status

Coverage decreased (-2.0e-05%) to 99.918% when pulling b217cc6 on piotr-kaminski-intel:master into 2a0bc60 on Tencent:master.

Init variable in the constructor
line 358:
'this->notValidatorIndex_' might not be initialized in this constructor.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 10, 2017

Coverage Status

Coverage increased (+2.0e-05%) to 99.918% when pulling bb99ccb on piotr-kaminski-intel:master into 2a0bc60 on Tencent:master.

coveralls commented Oct 10, 2017

Coverage Status

Coverage increased (+2.0e-05%) to 99.918% when pulling bb99ccb on piotr-kaminski-intel:master into 2a0bc60 on Tencent:master.

@miloyip miloyip merged commit bf82259 into Tencent:master Oct 20, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.0e-05%) to 99.918%
Details
@miloyip

This comment has been minimized.

Show comment
Hide comment
@miloyip

miloyip Oct 20, 2017

Collaborator

Thanks

Collaborator

miloyip commented Oct 20, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment