Skip to content

/ rapidjson

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings/errors on GCC 7/8 (-Wclass-memaccess, -Wsign-conversion, -Wformat-overflow) #1323

Merged
merged 3 commits into from Jul 16, 2018
Merged

Fix warnings/errors on GCC 7/8 (-Wclass-memaccess, -Wsign-conversion, -Wformat-overflow) #1323

merged 3 commits into from Jul 16, 2018

Conversation

@pah
Copy link
Contributor

@pah pah commented Jul 15, 2018 •
edited

Recent GCC versions warn about using memcpy/memmove to write to a class pointer (-Wclass-memaccess). This has been reported multiple times now, but the suppressions in the master branch are not complete.

This PR avoids the warnings by casting the destination pointer to void* first.

Closes #1086.
Closes #1205.
Closes #1246.

Additional warnings are fixed / suppressed as discovered during testing:

  • Fix -Wsign-conversion warnings/errors (a26267d)
  • Suppress -Wformat-overflow warning/error (1525116)
@pah
Fix -Wclass-memaccess warnings/errors
Loading status checks…
fa5963a 
Recent GCC versions warn about using memcpy/memmove to
write to a class pointer (-Wclass-memaccess).

Avoid the warnings by casting to void* first.

Closes #1086.
Closes #1205.
Closes #1246.
@coveralls
Copy link

@coveralls coveralls commented Jul 15, 2018 •
edited

Coverage Status

Coverage increased (+0.001%) to 99.922% when pulling 1525116 on pah:fix-memaccess into 4b4583b on Tencent:master.
pah added 2 commits Jul 15, 2018
@pah
Fix -Wsign-conversion warnings/errors
a26267d 
GCC 8 (incorrectly) warns about sign conversions in (constant)
array size expressions:

error: conversion to 'long unsigned int' from 'int' may
change the sign of the result [-Werror=sign-conversion]
     char schemaBuffer_[128 * 1024];

Make these expressions unsigned by adding a 'u' suffix to
the first operands.
@pah
Suppress -Wformat-overflow warning/error
Loading status checks…
1525116 
GCC 7 and later warn about overflow/truncation when using
sprintf and related functions with fixed-size buffers.

Suppress the warning in schematest.cpp.
@pah pah changed the title Fix -Wclass-memaccess warnings/errors Fix warnings/errors on GCC 7/8 (-Wclass-memaccess, -Wsign-conversion, -Wformat-overflow) Jul 15, 2018
@miloyip miloyip merged commit 2bbd33b into Tencent:master Jul 16, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 99.922%
Details
@miloyip
Copy link
Collaborator

@miloyip miloyip commented Jul 16, 2018

Thanks again.
@pah pah deleted the pah:fix-memaccess branch Jul 16, 2018
@kkaefer kkaefer mentioned this pull request Jul 16, 2018
Closed
@kjkh kjkh mentioned this pull request Aug 17, 2018
Closed
1 of 7 tasks complete
@lev95 lev95 mentioned this pull request Nov 19, 2018
Closed
@Krutonium Krutonium mentioned this pull request Sep 5, 2019
Open
@lazka lazka mentioned this pull request Dec 5, 2019
Closed
@svde svde mentioned this pull request Dec 22, 2019
Closed
@chwarr chwarr mentioned this pull request May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Warning with gcc 8.1 [-Wclass-memaccess]
Provided tests fail to compile
-Wclass-memaccess triggered by GCC7
3 participants
@pah @coveralls @miloyip
You can’t perform that action at this time.