New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RAPIDJSON_NOEXCEPT_ASSERT #1329

Merged
merged 3 commits into from Sep 11, 2018

Conversation

Projects
None yet
4 participants
@pah
Contributor

pah commented Jul 18, 2018

This is an alternative implementation to #1284 to handle asserts in noexcept contexts.
See #1284 (comment).

Closes #1280.

Add RAPIDJSON_NOEXCEPT_ASSERT
This is an alternative implementation to #1284 to handle
asserts in noexcept contexts.

Closes #1280.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 18, 2018

Coverage Status

Coverage decreased (-0.001%) to 99.921% when pulling 783b819 on pah:fix-noexcept into f5f6052 on Tencent:master.

coveralls commented Jul 18, 2018

Coverage Status

Coverage decreased (-0.001%) to 99.921% when pulling 783b819 on pah:fix-noexcept into f5f6052 on Tencent:master.

@tencent-adm

This comment has been minimized.

Show comment
Hide comment
@tencent-adm

tencent-adm Sep 10, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

miloyip
pah
You have signed the CLA already but the status is still pending? Let us recheck it.

tencent-adm commented Sep 10, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

miloyip
pah
You have signed the CLA already but the status is still pending? Let us recheck it.

@miloyip miloyip merged commit c0ca05f into Tencent:master Sep 11, 2018

2 of 4 checks passed

coverage/coveralls Coverage decreased (-0.001%) to 99.921%
Details
license/cla Contributor License Agreement is not signed yet.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment