New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case on kParseNumbersAsStringsFlag being able to load big ints #1373

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
3 participants
@lelit
Contributor

lelit commented Oct 8, 2018

See issue #1368.

@miloyip

This comment has been minimized.

Show comment
Hide comment
@miloyip

miloyip Oct 8, 2018

Collaborator

I think it should also check whether the parsed string is as expected.

Collaborator

miloyip commented Oct 8, 2018

I think it should also check whether the parsed string is as expected.

@lelit

This comment has been minimized.

Show comment
Hide comment
@lelit

lelit Oct 8, 2018

Contributor

Ok, sure!

Contributor

lelit commented Oct 8, 2018

Ok, sure!

@lelit

This comment has been minimized.

Show comment
Hide comment
@lelit

lelit Oct 8, 2018

Contributor

Uhm, maybe I'm missing something, but isn't that already checked by the handler's RawNumber() method?

Contributor

lelit commented Oct 8, 2018

Uhm, maybe I'm missing something, but isn't that already checked by the handler's RawNumber() method?

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 8, 2018

Coverage Status

Coverage remained the same at 99.921% when pulling 91d50c8 on lelit:issue1368 into 663f076 on Tencent:master.

coveralls commented Oct 8, 2018

Coverage Status

Coverage remained the same at 99.921% when pulling 91d50c8 on lelit:issue1368 into 663f076 on Tencent:master.

@miloyip

This comment has been minimized.

Show comment
Hide comment
@miloyip

miloyip Oct 8, 2018

Collaborator

Oh, true.

Collaborator

miloyip commented Oct 8, 2018

Oh, true.

@miloyip miloyip merged commit 67fac85 into Tencent:master Oct 8, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.921%
Details

@lelit lelit deleted the lelit:issue1368 branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment