Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复文档中的错误 #1544

Open
wants to merge 2 commits into
base: master
from

Conversation

@fredgan
Copy link

commented Jul 19, 2019

No description provided.

fredgan added some commits Jul 16, 2019

Merge pull request #1 from Tencent/master
Change all GenericMemberIterator from struct to class
@coveralls

This comment has been minimized.

Copy link

commented Jul 19, 2019

Coverage Status

Coverage increased (+0.003%) to 99.922% when pulling 9e1acba on fredgan:master into d87b698 on Tencent:master.

@fredgan

This comment has been minimized.

Copy link
Author

commented Jul 20, 2019

@miloyip 看起来那两个自动构建check有点问题呢

@@ -72,7 +72,7 @@
* 只储存指针,不作复制
* 优化“短”字符串
*`Value` 内储存短字符串,无需额外分配。
* 对 UTF-8 字符串来说,32 位架构下可存储最多 11 字符,64 位下 21 字符(x86-64 下 13 字符)。
* 对 UTF-8 字符串来说,32 位架构下可存储最多 11 字符,64 位下 21 字符(x86-64 下 15 字符)。

This comment has been minimized.

Copy link
@miloyip

miloyip Jul 22, 2019

Collaborator

这数字你确定么?

This comment has been minimized.

Copy link
@fredgan

fredgan Jul 22, 2019

Author

这个21字符我不确定是怎么来的,但是这个15个字符的是你短字符串优化中的方案。32位的Value占用16个字节,64位的Value占用20字节,除去一个字节的长度和4个字节的flag_,因此32位最多存储短字符串11个字节长度,64位最多存储15字节短字符串长度。

This comment has been minimized.

Copy link
@fredgan

fredgan Jul 24, 2019

Author

请问milo大大,有什么问题吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.