Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pointer tokens to have non-null-terminated strings #1567

Merged
merged 3 commits into from Sep 12, 2019

Conversation

@AtnNn
Copy link
Contributor

commented Sep 11, 2019

The following code:

v->FindMember(GenericStringRef<Ch>(t->name, t->length))

Was calling the FindMember(const Ch*) overload, causing the t->length to be ignored. With this change, it now calls the GenericValue overload with a properly constructed string.

@tencent-adm

This comment has been minimized.

Copy link

commented Sep 11, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls

This comment has been minimized.

Copy link

commented Sep 11, 2019

Coverage Status

Coverage increased (+0.003%) to 99.922% when pulling 6102f0b on AtnNn:master into 2648a73 on Tencent:master.

@miloyip miloyip merged commit fcec773 into Tencent:master Sep 12, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
license/cla Contributor License Agreement is not signed yet.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miloyip

This comment has been minimized.

Copy link
Collaborator

commented Sep 12, 2019

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.