New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% line of code coverage #304

Merged
merged 67 commits into from Apr 15, 2015

Conversation

Projects
None yet
2 participants
@miloyip
Collaborator

miloyip commented Apr 15, 2015

This pull request mainly modifies the unit tests in order to cover all line-of-code.
The progress and results can be viewed on coveralls.

But there are also some important changes in RapidJSON code:

  1. 4824f12 A bug is discovered and fixed.
  2. e7f1c6d An invalid API is removed.
  3. 4be4857, 37d820a Some unused functions/conditions in double-string conversions are removed.

Although more tests have been added, it may be still prone to error due to such large number of changes (1,020 additions and 254 deletions).

I prefer deferring the official release and create a release candidate first when all new bugs have been fixed.

miloyip added some commits Apr 13, 2015

miloyip and others added some commits Apr 14, 2015

Use assertion for impossible case(The Predict() can ensure the token …
…is ColonToken, otherwise it would be marked as Error state. So there is no need to check ColonToken again).
Assert on impossible state transition in Transit(); Put the last case…
… and all non-enumerated cases(also supply assertion for them) in for code coverage.
Merge pull request #302 from thebusytypist/issue298_coverage
Improve code coverage for iterative parsing

miloyip added a commit that referenced this pull request Apr 15, 2015

Merge pull request #304 from miloyip/issue298_coverage
100% line of code coverage

@miloyip miloyip merged commit 75ee552 into master Apr 15, 2015

2 of 3 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@miloyip

This comment has been minimized.

Show comment
Hide comment
@miloyip

miloyip Apr 15, 2015

Collaborator

Fix #298

Collaborator

miloyip commented Apr 15, 2015

Fix #298

@miloyip miloyip deleted the issue298_coverage branch Apr 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment