-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dialog] 实例里的方法都是存在的,为什么定义成可选的类型? #1782
Comments
👋 @moecasts,感谢给 TDesign 提出了 issue。 |
改 |
moecasts
added a commit
to moecasts/tdesign-react
that referenced
this issue
Dec 7, 2022
16 tasks
honkinglin
pushed a commit
that referenced
this issue
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tdesign-react 版本
0.44.0
重现链接
No response
重现步骤
定义成可选的话,老代码都要改成
dialog.hide?.()
,对于已经大量使用dialog
组件的项目极不友好。期望结果
tdesign-react/src/dialog/type.ts
Lines 167 to 184 in 8b09761
实际结果
可以将类型定义成必选的。
框架版本
No response
浏览器版本
No response
系统版本
No response
Node版本
No response
补充说明
No response
The text was updated successfully, but these errors were encountered: