From ad2e9ee51f3035dc287a60f070c87651960cbb1f Mon Sep 17 00:00:00 2001
From: Luo Fan <44999219+fannluo@users.noreply.github.com>
Date: Fri, 12 Apr 2019 19:11:12 +0800
Subject: [PATCH] =?UTF-8?q?improvement:=20=E6=A0=87=E5=87=86=E6=8F=92?=
 =?UTF-8?q?=E4=BB=B6Tag=E8=A1=A8=E5=8D=95=E6=94=AF=E6=8C=81changeHook?=
 =?UTF-8?q?=E6=96=B9=E6=B3=95=20#81=20(#82)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* feature: 标准插件Tag表单支持changeHook方法

* minor:Tag表单项label margin 样式
---
 .../components/common/RenderForm/FormItem.vue   | 17 +++++++++++++----
 .../components/common/RenderForm/formMixins.js  |  4 ++++
 .../pages/template/TemplateEdit/NodeConfig.vue  |  4 ++++
 3 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/pipeline/blueflow/src/components/common/RenderForm/FormItem.vue b/pipeline/blueflow/src/components/common/RenderForm/FormItem.vue
index b4e33ea628..545e1ca620 100644
--- a/pipeline/blueflow/src/components/common/RenderForm/FormItem.vue
+++ b/pipeline/blueflow/src/components/common/RenderForm/FormItem.vue
@@ -10,7 +10,16 @@
 * specific language governing permissions and limitations under the License.
 */
 <template>
-    <div :class="['rf-form-item', 'clearfix', {'rf-has-hook': showHook}]" v-show="showForm">
+    <div
+        :class="[
+            'rf-form-item',
+            'clearfix',
+            {
+                'rf-has-hook': showHook,
+                'show-label': option.showLabel
+            }
+        ]"
+        v-show="showForm">
         <div v-if="!hook && option.showGroup && scheme.attrs.name" class="rf-group-name">
             <span class="name">{{scheme.attrs.name}}</span>
             <span v-if="scheme.attrs.desc" class="rf-group-desc">
@@ -29,11 +38,11 @@
             :class="['rf-tag-label', {'required': isRequired()}]">
             {{scheme.attrs.name}}
         </label>
-        <div v-if="hook" class="rf-tag-form">
+        <div v-show="hook" class="rf-tag-form">
             <el-input :disabled="true" :value="String(value)"></el-input>
         </div>
         <component
-            v-else
+            v-show="!hook"
             class="rf-tag-form"
             ref="tagComponent"
             :is="tagComponent"
@@ -332,7 +341,7 @@ export default {
             }
         }
     }
-    .rf-tag-label + .rf-tag-form {
+    &.show-label > .rf-tag-form {
         margin-left: 120px;
     }
     .rf-tag-hook {
diff --git a/pipeline/blueflow/src/components/common/RenderForm/formMixins.js b/pipeline/blueflow/src/components/common/RenderForm/formMixins.js
index 41a6aaa9d2..f6139ed8c7 100644
--- a/pipeline/blueflow/src/components/common/RenderForm/formMixins.js
+++ b/pipeline/blueflow/src/components/common/RenderForm/formMixins.js
@@ -224,8 +224,12 @@ export function getFormMixins (attrs = {}) {
                 this.$emit('onShow')
             },
             hide () {
+                this.changeHook(false)
                 this.$emit('onHide')
             },
+            changeHook (val) {
+                this.$parent.onHookForm(val)
+            },
             // 获取 form 项实例
             get_form_instance () {
                 return this.$parent
diff --git a/pipeline/blueflow/src/pages/template/TemplateEdit/NodeConfig.vue b/pipeline/blueflow/src/pages/template/TemplateEdit/NodeConfig.vue
index 29b86d0404..ff59045f88 100644
--- a/pipeline/blueflow/src/pages/template/TemplateEdit/NodeConfig.vue
+++ b/pipeline/blueflow/src/pages/template/TemplateEdit/NodeConfig.vue
@@ -972,6 +972,10 @@ export default {
             } else {  // cancel hook
                 variableKey = this.inputAtomData[key] // variable key
                 const variable = this.constants[variableKey]
+                if (!variable) {
+                    return
+                }
+
                 const formKey = this.isSingleAtom ? tagCode : key // input arguments form item key
                 this.inputAtomHook[formKey] = val
                 this.inputAtomData[formKey] = tools.deepClone(this.constants[variableKey].value)