New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify minimal required ansible version #1055
Conversation
run tests |
There might be some problem with the running ansible updating itself on the Tendrl server. I'll need to debug it slightly more deeply. |
This patch might cause update of ansible package on Tendrl Server, when ansible-playbook is running (with
I'm not sure now, what is the best solution for this. |
@dahorak If we update the spec file of tendrl-ansible itself ( https://github.com/Tendrl/tendrl-ansible/blob/4acae343ad4fab4f16ce330e047403374d0cb7a6/tendrl-ansible.spec#L15 ) , Wouldn't it solve the issue ? |
As I wrote under the related issue, the main "problem" here is, that the expected ansible version (2.6) is in epel repository, which is added "automatically" when tendrl-ansible's |
@anmolsachan both tendrl-ansible and tendrl-commons requires ansible, so both should specify the minimal version. In upstream, one can try to use tendrl-ansible on another machine or install it from git repo, and in such case, minimal version in tendrl-commons will have it's effect. |
@dahorak Need to specify the minimum version of ansible in setup.py also, otherwise it won't work when I do |
Codecov Report
@@ Coverage Diff @@
## master #1055 +/- ##
=========================================
Coverage ? 82.39%
=========================================
Files ? 90
Lines ? 3709
Branches ? 477
=========================================
Hits ? 3056
Misses ? 555
Partials ? 98 Continue to review full report at Codecov.
|
LGMT |
0426566
to
49e78fa
Compare
LGTM |
1 similar comment
LGTM |
Fix the commit message, pep8 and squash in one commit. |
49e78fa
to
e2c101d
Compare
tendrl-bug-id: Tendrl#1054 Signed-off-by: Daniel Horak <dahorak@redhat.com>
e2c101d
to
3bd3c2a
Compare
- epel is now required to be enabled before tendrl-ansible installation on tendrl_server Tendrl/commons#1055 (comment)
Signed-off-by: Daniel Horak dahorak@redhat.com