Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] File Upload: add custom form data #546

Closed
farkidev opened this issue May 3, 2017 · 3 comments
Closed

[feature request] File Upload: add custom form data #546

farkidev opened this issue May 3, 2017 · 3 comments

Comments

@farkidev
Copy link

farkidev commented May 3, 2017

This repository's issues are reserved for feature requests and bug reports.

Do you want to request a feature or report a bug?

feature

Feature Request

What is the expected behavior?

A key value pair or FormData parameter should be added to IUploadOptions where we can pass custom form data e.g. file type, comment, etc.

What is the motivation / use case for changing the behavior?

I now we can headers but I think these kind of data doesn't belong to the header

Other information

If you are interested I can do it and create a pull request.

@emoralesb05
Copy link
Contributor

Sure, really interested in a PR with that 😄

@ghost
Copy link

ghost commented May 9, 2017

Today I made the necessary changes (this is my work account) but when I run ng serve --aot I get a JavaScript heap out of memory. (Everything else is working including ng build --aot.) There is an open issue about it at the cli repo.
Should I create a PR with the my new feature branch anyway?

@emoralesb05
Copy link
Contributor

Sure, PR away and we can start discussing this kinds of things in the PR. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants