Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kylo 1234 index categories and feeds #53

Closed
wants to merge 2 commits into from

Conversation

@fabiannecci
Copy link
Contributor

commented Sep 26, 2017

POC for indexing Kylo's categories and feeds data on the kylo-data index, creating an elasticsearch parent/child relationship between the two documents.

Fabian Necci added 2 commits Sep 26, 2017
…ategories and feeds on elastic search
* %%
* Copyright (C) 2017 ThinkBig Analytics
* %%
* Licensed under the Apache License, Version 2.0 (the "License");

This comment has been minimized.

Copy link
@KyloTech

KyloTech Sep 26, 2017

MAJOR This block of commented-out lines of code should be removed. rule

}

@Override
public void index(@Nonnull String indexName, @Nonnull String typeName, @Nonnull String id, @Nonnull Map<String, Object> fields, String parentId) {
buildRestClient();
try {

This comment has been minimized.

Copy link
@KyloTech

KyloTech Sep 26, 2017

CRITICAL Change this "try" to a try-with-resources. rule

@KyloTech

This comment has been minimized.

Copy link

commented Sep 26, 2017

SonarQube analysis reported 44 issues

  • CRITICAL 6 critical
  • MAJOR 16 major
  • MINOR 22 minor

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ElasticSearchRestService.java#L75: Make "restClient" transient or serializable. rule
  2. CRITICAL ElasticSearchRestService.java#L247: Refactor this method to reduce its Cognitive Complexity from 39 to the 15 allowed. rule
  3. CRITICAL ElasticSearchRestService.java#L392: Define a constant instead of duplicating this literal "query" 4 times. rule
  4. CRITICAL ElasticSearchService.java#L58: Make "client" transient or serializable. rule
  5. CRITICAL SearchIndex.java#L26: Move constants to a class or enum. rule
  6. MAJOR ElasticSearchRestService.java#L9: This block of commented-out lines of code should be removed. rule
  7. MAJOR ElasticSearchRestSpringConfiguration.java#L9: This block of commented-out lines of code should be removed. rule
  8. MAJOR ElasticSearchService.java#L9: This block of commented-out lines of code should be removed. rule
  9. MAJOR ElasticSearchService.java#L143: Define and throw a dedicated exception instead of using a generic one. rule
  10. MAJOR SolrSearchService.java#L9: This block of commented-out lines of code should be removed. rule
* %%
* Copyright (C) 2017 ThinkBig Analytics
* %%
* Licensed under the Apache License, Version 2.0 (the "License");

This comment has been minimized.

Copy link
@KyloTech

KyloTech Sep 26, 2017

MAJOR This block of commented-out lines of code should be removed. rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.