Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Locomotive Carts #1

Merged
merged 3 commits into from Jul 6, 2019

Conversation

@mayant15
Copy link
Collaborator

commented Jul 3, 2019

Extracts the locomotive cart from the AdditionalRails module. Also fixes #2 .

To Test:

  • Get some rail blocks with give rails and place them
  • Get the loco using give locoItem and place it on the rail track
  • Press e to activate the locomotive
    final loco

@mayant15 mayant15 marked this pull request as ready for review Jul 6, 2019

@Cervator
Copy link
Member

left a comment

Works great! Leaving some general code quality requests.

Show resolved Hide resolved assets/atlas/minecart.atlas Outdated
Show resolved Hide resolved assets/prefabs/items/locoItem.prefab Outdated
Show resolved Hide resolved assets/prefabs/vehicles/loco.prefab Outdated
Show resolved Hide resolved src/main/java/actions/LocomotiveAction.java Outdated
Show resolved Hide resolved src/main/java/actions/LocomotiveAction.java Outdated
Show resolved Hide resolved src/main/java/actions/LocomotiveAction.java Outdated
Show resolved Hide resolved src/main/java/actions/LocomotiveAction.java Outdated
Show resolved Hide resolved src/main/java/actions/LocomotiveAction.java Outdated

@Cervator Cervator merged commit 417ee7c into Terasology:master Jul 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.