Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add city centre icon to minimap #42

Merged
merged 5 commits into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@mayant15
Copy link
Contributor

commented Jun 2, 2019

TODO

  • Fix icon size variation on zoom
  • Make the icon persist

This PR adds an icon at the city centre. The icon stays on the map even when the city moves out of view, for easier navigation.

To Test:

  • Start a game with DynamicCities enabled
  • Enter a city. The overlay is added to the minimap
  • An icon should be present at the centre of the city
  • Now move around such that the city centre moves out of the area covered by the map. The icon should persist at the boundary of the map in the direction of the city centre.

@mayant15 mayant15 changed the title [WIP] Add city centre icon to minimap Add city centre icon to minimap Jun 4, 2019

@iaronaraujo
Copy link
Contributor

left a comment

Added a comment in the code with a change suggestion. Also, it would be nice to add Javadoc to the classes and public methods!

@iaronaraujo iaronaraujo merged commit a0f6e52 into Terasology:master Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.