Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix structure template placement issues #49

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@AndyTechGuy
Copy link
Contributor

commented Jul 30, 2019

Contains

A fix for #35. Fixes building placement by resolving a faulty block region rotation in Construction.java. The block region was rotating around (0,0,0) instead of around the center of the structure's parcel, resulting in templates spawning far away from the target parcel unless no rotation was used.

The templates now spawn properly on the centre of their parcels:

image
using Terasology/MetalRenegades#11

This requires Terasology/StructureTemplates#31 to work properly!

One caveat with structure template placement at this point, the placement becomes less regular when using non-square sizes. This seems to be a parcel issue, since parcel sizes are chosen at random between the lowest and longest x-y length provided. Sometimes this results in a regular shape, but other times it may look uneven:

image
using Terasology/MetalRenegades

@AndyTechGuy AndyTechGuy merged commit 5490829 into Terasology:master Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.