Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate minimap with LASTeam based icons #104

Open
wants to merge 2 commits into
base: master
from

Conversation

@darshan3
Copy link
Member

commented Aug 15, 2019

No description provided.

@@ -51,6 +51,8 @@
public static final String WHITE_HEALTH_SKIN = "lightAndShadowResources:healthWhite";
public static final String RED_HEALTH_SKIN = "lightAndShadowResources:healthRed";
public static final String BLACK_HEALTH_SKIN = "lightAndShadowResources:healthBlack";
public static final String RED_MINIMAP_ICON = "lightAndShadowResources:heartsIcon";

This comment has been minimized.

Copy link
@skaldarnar

skaldarnar Aug 20, 2019

Contributor

As pointed out in Terasology/LightAndShadowResources#31 (review) you might just use the icons that are already there:

Suggested change
public static final String RED_MINIMAP_ICON = "lightAndShadowResources:heartsIcon";
public static final String RED_MINIMAP_ICON = "lightAndShadowResources:heart";
@@ -51,6 +51,8 @@
public static final String WHITE_HEALTH_SKIN = "lightAndShadowResources:healthWhite";
public static final String RED_HEALTH_SKIN = "lightAndShadowResources:healthRed";
public static final String BLACK_HEALTH_SKIN = "lightAndShadowResources:healthBlack";
public static final String RED_MINIMAP_ICON = "lightAndShadowResources:heartsIcon";
public static final String BLACK_MINIMAP_ICON = "lightAndShadowResources:spadesIcon";

This comment has been minimized.

Copy link
@skaldarnar

skaldarnar Aug 20, 2019

Contributor

As pointed out in Terasology/LightAndShadowResources#31 (review) you might just use the icons that are already there:

Suggested change
public static final String BLACK_MINIMAP_ICON = "lightAndShadowResources:spadesIcon";
public static final String BLACK_MINIMAP_ICON = "lightAndShadowResources:spade";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.