Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health hud fix for reconnects and restarts #90

Merged
merged 2 commits into from Jun 16, 2019

Conversation

@darshan3
Copy link
Member

commented Jun 12, 2019

Project Cards:

  1. Handle loading from saved game and client reconnects

How to test:

  1. Host a Light and Shadow game
  2. Join the game using one more client instance
  3. Choose one team with each of the players
  4. Leave the game for one of the clients and join in again.
  5. Close the game and try loading the game back from save and join using other clients again.

Expected outcome:
Health HUD should be initially white dots and it should change to Spades for black team, hearts for red team.

@skaldarnar

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

This does work for a single client re-joining a game, and for the host when quitting the game and then hosting it again (loading the same game).
However, it does not work for a previously connected client if they lost connection because the host quit. Player appears as white and also has the white dots.

Terasology-190614000627-1152x720
image

@skaldarnar

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

On the upside, it works if the client disconnects before the host. When re-joining after the host is up again the HUD is correct.
What's the difference between a graceful disconnect and losing connection to the server?

@darshan3 darshan3 added this to In progress in GSOC 2019: Light & Shadows Jun 16, 2019

@iaronaraujo
Copy link
Contributor

left a comment

The code seems to be ok! I didn't get to test this though

@skaldarnar skaldarnar merged commit 1db446d into master Jun 16, 2019

GSOC 2019: Light & Shadows automation moved this from In progress to Done Jun 16, 2019

@skaldarnar skaldarnar deleted the HealthHUDFix branch Jun 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.