Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trading with NPCs #24

Merged
merged 11 commits into from Aug 9, 2019

Conversation

@mayant15
Copy link
Collaborator

commented Aug 2, 2019

To Test:

  • Go and interact with any NPC
  • After the first page of dialogue, a trading UI should come up
  • Select the item that you want from the left list, select the item that you'll offer from the right list and click the button below
  • If the citizen accepts the trade, you should have the item you selected. Otherwise, you'll get a message saying "Offer declined"

trade_gif

@mayant15 mayant15 marked this pull request as ready for review Aug 4, 2019

@iaronaraujo
Copy link
Contributor

left a comment

Code looks good, but can you add Javadoc in the near future if possible?

@mayant15

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 7, 2019

@iaronaraujo I did add javadocs. Is there a specific class/function where you want them?

@iaronaraujo

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

I was thinking you could add some javadoc to the classes' attributes, what do you think?
If you want you can merge this PR and then do this later

@mayant15 mayant15 merged commit 95352cc into Terasology:master Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.