Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate tooltips, with information for citizen needs #26

Open
wants to merge 4 commits into
base: master
from

Conversation

@AndyTechGuy
Copy link
Collaborator

commented Aug 5, 2019

Contains

Integrates Terasology/WorldlyTooltip to add tooltips for all blocks. For all citizen characters, this tooltip includes information about current needs, which looks like below:

CitizenTooltip

To test, activate this commit and look at any citizen character; the tooltip should look similar to above.

@Cervator

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Hey @AndyTechGuy can you give this another look? I just tried to test it but each time I hover over a Gooey I get the following NPE:

10:02:49.143 [main] INFO  o.t.d.construction.BlockBufferSystem - Buffer before: 12127, Placed: 1000, Removed: 1000, Buffer after: 11127
10:02:49.554 [main] ERROR o.t.e.event.internal.EventSystemImpl - Failed to invoke event
java.lang.NullPointerException: null
	at org.terasology.input.InputSystem.getInputsForBindButton(InputSystem.java:538)
	at org.terasology.dialogs.DialogSystem.createTalkText(DialogSystem.java:196)
	at org.terasology.dialogs.DialogSystem.updateTalkNotification(DialogSystem.java:110)
	at org.terasology.dialogs.DialogSystem.onTarget(DialogSystem.java:99)
	at org.terasology.dialogs.DialogSystemMethodAccess.invoke(Unknown Source)
	at org.terasology.entitySystem.event.internal.EventSystemImpl$ByteCodeEventHandlerInfo.invoke(EventSystemImpl.java:531)
	at org.terasology.entitySystem.event.internal.EventSystemImpl.sendStandardEvent(EventSystemImpl.java:291)
	at org.terasology.entitySystem.event.internal.EventSystemImpl.send(EventSystemImpl.java:282)
	at org.terasology.entitySystem.entity.internal.BaseEntityRef.send(BaseEntityRef.java:205)
	at org.terasology.input.cameraTarget.PlayerTargetSystem.update(PlayerTargetSystem.java:87)
	at org.terasology.engine.modes.StateIngame.update(StateIngame.java:171)
	at org.terasology.engine.TerasologyEngine.tick(TerasologyEngine.java:463)
	at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:426)
	at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:402)
	at org.terasology.engine.Terasology.main(Terasology.java:156)
10:02:50.153 [main] INFO  o.t.d.construction.BlockBufferSystem - Buffer before: 11127, Placed: 1000, Removed: 1000, Buffer after: 10127

That may be from unrelated work, unsure. I get the tooltip enabled for other stuff fine.

@AndyTechGuy

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 13, 2019

That NPE isn't from this PR, I checked it out and it also occurs in the master branch. Seems to be something with the Dialog module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.