Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic fetch quests #27

Merged
merged 6 commits into from Aug 10, 2019

Conversation

@mayant15
Copy link
Collaborator

commented Aug 6, 2019

Requirements:

To Test:

  • Go to a quest point in church and receive an item with the quest
  • Activate the item and complete the tasks
  • When the last task is started, the quest point that you started with will now be a beacon. Go back to the same point to complete the quest.
  • The collected items should be removed from the inventory and the player will get 50 cash.

Issues:

  • Because beaconIds are the same, if the same quest is taken multiple times, players don't need to go back to the beacon. Quests complete as soon as they collect items.
  • The beacon overlay marks the wrong point on the minimap.

Possible Improvements:

  • Add quests to citizens and have some dialog, allowing the player to accept/decline the quest
@mayant15 mayant15 marked this pull request as ready for review Aug 9, 2019
@ReceiveEvent(components = GenericBuildingComponent.class)
public void onChurchSpawn(BuildingEntitySpawnedEvent event, EntityRef entityRef) {
GenericBuildingComponent genericBuildingComponent = entityRef.getComponent(GenericBuildingComponent.class);
if (genericBuildingComponent.name.equals("simplechurch")) {

This comment has been minimized.

Copy link
@msteiger

msteiger Aug 9, 2019

Member

It think that it would be good if there was a better way to identify the building component. Maybe we should at least define a few String constants so we can track usages and possible renames.

@mayant15 mayant15 merged commit c238f46 into Terasology:master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.