Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Generators #22

Open
wants to merge 27 commits into
base: master
from
Open

More Generators #22

wants to merge 27 commits into from

Conversation

@Qwertygiy
Copy link

Qwertygiy commented Oct 15, 2019

WIP -- not ready to merge yet.

Things I have added thus far:

  • Organizing the prefabs into folders (animals, people, places)
  • Many more names for bodies of water, rather than just the existing five
  • Many more nobility titles, as well as allowing titles that do not properly work with "the"
  • Non-procedural regional adjectives with procedural prefixes (e.g. English, New Chinese, Manchurian, Greater Floridian)
  • Non-procedural animal adjectives with procedural prefixes (e.g. Green, Scaly, Star-spotted, Aquatic-toothed)
  • Non-procedural animal names with procedural prefixes (e.g. Rabbit, Woodchicken, Bushowl)
  • Combining the three above categories (e.g. West Georgian Blue-Eyed Waterdog)
  • Procedural city names for Roman, Ancient Greek, Ancient Egyptian, Modern French, Modern Spanish, Edo Japan
  • Procedural human names for Roman, Ancient Greek, Ancient Egyptian, Modern French, Modern Spanish, Edo Japan
  • Procedural region names for Ancient Rome, Ancient Greece, Modern French, Modern Spain, Edo Japan
Copy link
Contributor

skaldarnar left a comment

A lot to review - could you either split this up into single PRs for individual generators or separate it by prefab additions (part 1) and java additions (part 2)

@@ -0,0 +1,143 @@
{
"TownNameAffix": {

This comment has been minimized.

Copy link
@skaldarnar

skaldarnar Oct 15, 2019

Contributor

TownNameAffix looks wrong here

This comment has been minimized.

Copy link
@Qwertygiy

Qwertygiy Oct 15, 2019

Author

It's the name of the existing Prefix/Postfix system; it has nothing particularly unique to towns, as far as I can ascertain. It could do with a refactoring.

@skaldarnar

This comment has been minimized.

Copy link
Contributor

skaldarnar commented Oct 15, 2019

... or I have to review commit by commit 🤔

@Qwertygiy

This comment has been minimized.

Copy link
Author

Qwertygiy commented Oct 15, 2019

The Changed Files list might be a better place to look than each individual commit, especially as I reorganized things several times.

A lot of the generators I'm working on are linked piecemeal into creating a single, complex animal name generator. I could probably divide it into culture additions vs. creature additions, if need be.

Copy link
Contributor

skaldarnar left a comment

Wow, that's a bunch of changes 😮 left some comments with requests for changes 🙃

Qwertygiy added 3 commits Jan 28, 2020
@Qwertygiy

This comment has been minimized.

Copy link
Author

Qwertygiy commented Jan 28, 2020

Finally plowed through the majority of the review notes here, cleaning up what I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.