Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change path to not extend ArrayList #39

Merged
merged 5 commits into from Aug 10, 2019

Conversation

@AndyTechGuy
Copy link
Contributor

commented Jul 21, 2019

The Path object used to extend ArrayList, but this doesn't allow paths to be saved in components, which breaks pathfinding in Terasology/Behaviors. This changes path to not extend ArrayList, but rather have all the nodes stored as a property inside of the path.

Could potentially break modules that directly use properties of ArrayList, I checked many modules for this but there may be one that I missed

This also changes the version from 0.3.0 -> 0.3.1 to indicate the compatibility change

@AndyTechGuy AndyTechGuy referenced this pull request Jul 21, 2019
2 of 2 tasks complete
@jellysnake

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

You could extend the Iterable interface which allows you to use the class in the for(Foo foo : bar){} construct

@AndyTechGuy AndyTechGuy merged commit ebbece0 into Terasology:master Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.