Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bottom centre block region calculation #31

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@AndyTechGuy
Copy link
Contributor

commented Jul 30, 2019

Contains

A fix for BlockRegionUtilities.determineBottomCenter, where the x & z coordinates are inverted, resulting in a point sometimes outside of the bounding box.

Could potentially break compatibility with modules using the old version of this calculation, a version update may be needed

Required for Terasology/DynamicCities#49 to work properly.

@msteiger
Copy link
Member

left a comment

I'm surprised that it had the minus in there before ...

@AndyTechGuy AndyTechGuy merged commit ce2f844 into Terasology:master Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.