Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasicRendering module - reconnect all nodes #1

Open
wants to merge 25 commits into
base: master
from

Conversation

@dave2s
Copy link
Contributor

commented Jul 14, 2019

This PR for Render DAG enhancement PR contains rendering nodes and their setup. It's a primary step for moving Terasology's rendering to modules.

  • Moved all nodes to a separate module BasicRendering
  • Reconnected all nodes via Fbo and BufferPair cnnections
  • Output is wrong, needs fixing

@dave2s dave2s requested a review from vampcat Jul 14, 2019

@dave2s dave2s self-assigned this Jul 14, 2019

dave2s added some commits Jul 15, 2019

BasicRenderingModule extends ModuleRendering(engine), hide context,re…
…nderGraph and worldRenderer, get access to module name (providingModule)

++ refactor main bufferPair creation, update bufferClearingNode with this - tricky, has some todos
Use bufferPairConnection between finalPostProcessingNode and OutputToScreenNode

@dave2s dave2s changed the title Move all nodes from engine to BasicRendering module BasicRendering module - reconnect all nodes Jul 16, 2019

@dave2s

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

  • Reconnected all nodes via Fbo and BufferPair cnnections
  • Output is wrong, needs fixing

dave2s added some commits Jul 16, 2019

BasicRenderingModule.java - Rendering Nodes: patch nodes' gbuffer con…
…nections (refractivereflectivenode), Update BufferPair creation trough displayDependentFbo manager for subscriber updates - MANDATORY for correct image output

, introduced renderGraph.connectRunOrder() connection to replace remaining connect() calls without direct materialistic(buffer) dependencies
Update basicRenderingModule.java ...take out haze and SSAO nodes, lea…
…ve late call of postinit data fetching/statechangerequesting method to preBegin() (another repository - engine based ModuleRendering.java)
@dave2s

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

seems haze is broken (at least on/off seems to result in the same output) ...now still a problem of both this repo and advancedRendering since basic rendering modules will still know about their advanced effects until feature sets are divided (not quite scope of gsoc 19 for DAG)

@dave2s dave2s marked this pull request as ready for review Jul 26, 2019

@dave2s

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

let's merge something to this repo, this PR already introduced enough

dave2s added some commits Aug 6, 2019

BasicRenderingModule.java - remove unused imports, add default initia…
…lizationPriority, add constructor, set default priority in parent
deferredMainLightNode.java DeferredPointLightsNode.java - edit Module…
…Rendering instance fetching trough RenderingModuleManager and RenderingModuleRegistry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.