New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vnc session crashes if click non-client area #28

Merged
merged 1 commit into from Jun 19, 2017

Conversation

3 participants
@takuya-takeuchi
Copy link
Contributor

takuya-takeuchi commented May 17, 2017

Fix:

  • VNC session always crashes if user click non-client screen area; black screen.
@jirkapok

This comment has been minimized.

Copy link
Contributor

jirkapok commented May 17, 2017

Thanks very much for contribution. The only question is, how to get such changes to original VncSharp source, so we dont have to compile our own version.

@jbowtie

This comment has been minimized.

Copy link

jbowtie commented May 23, 2017

@takuya-takeuchi Could you add a pull request upstream to https://github.com/humphd/VncSharp as well? That should allow @jirkapok to discuss with the upstream maintainer about if/when the fix can be released.

@takuya-takeuchi

This comment has been minimized.

Copy link
Contributor

takuya-takeuchi commented May 27, 2017

I'm so sorry for my delay response.

Could you add a pull request upstream to https://github.com/humphd/VncSharp as well?

Does it mean that I do the following command in folked Terminal local repo?
I am not sure whether my understand is correct.

git remote add upstream https://github.com/humphd/VncSharp

Thank you for your cooperations.

@jbowtie

This comment has been minimized.

Copy link

jbowtie commented May 28, 2017

@takuya-takeuchi I meant please fork the VncSharp repo and submit the same fix there.

@jirkapok

This comment has been minimized.

Copy link
Contributor

jirkapok commented May 29, 2017

Yes, please create pull request also into the VncSharp, i am not sure how much our version is compatible with original project.

@jirkapok jirkapok merged commit 1d8f886 into Terminals-Origin:master Jun 19, 2017

@jirkapok

This comment has been minimized.

Copy link
Contributor

jirkapok commented Jun 19, 2017

Pull request to original repo is not needed, since there is exact line match.

@takuya-takeuchi takuya-takeuchi deleted the takuya-takeuchi:feature/FixVncCrash branch Aug 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment