Regionprovider Region ID fetching optimisation #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevage
added a commit
to TerriaJS/nationalmap
that referenced
this pull request
Dec 22, 2015
| loadText('test/csv/mini_ced.xml').then(function(xml) { | ||
| ced.loadRegionsFromXML(xml); | ||
| expect(ced.regions.length).toEqual(6); | ||
| ced.loadRegionIDs().then(function(json) { |
There was a problem hiding this comment.
This isn't really a comment on your commit, but on the existing code - can you set it up so the unit tests didn't go off to a server at all, eg. using a spy? (eg. see ArcGisMapServerCatalogItemSpec)
There was a problem hiding this comment.
btw @kring's doing some cool work on this right now using sinon.fakeServer.create(), to solve the problem of failing unit tests on IE9 (which cannot load data from the region mapping server without a proxy).
|
OK, that's all I can think of! Over to you again :-) |
…r more realistic testing.
|
Looks good! Let me know when you're ready for me to take another look. |
|
Oh, yep, I'm ready - think I addressed everything. |
kring
added a commit
that referenced
this pull request
Jan 5, 2016
Regionprovider Region ID fetching optimisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR includes two separate optimisations: