Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regionMapping applyReplacements from v7 #5178

Merged
merged 4 commits into from
Jan 28, 2021
Merged

Add regionMapping applyReplacements from v7 #5178

merged 4 commits into from
Jan 28, 2021

Conversation

nf-s
Copy link
Contributor

@nf-s nf-s commented Jan 27, 2021

Add regionMapping applyReplacements from v7

This enables region mapping dataReplacements to work.

Also I started a typescript file to move region mapping stuff across - #4715

Checklist

  • Tests will wait until more Typescript has been written
  • I've updated CHANGES.md with what I changed.

@nf-s nf-s mentioned this pull request Jan 27, 2021
Closed
@KeyboardSounds KeyboardSounds self-assigned this Jan 28, 2021
KeyboardSounds
KeyboardSounds suggested changes Jan 28, 2021
View reviewed changes
lib/Table/TableColumn.ts Outdated Show resolved Hide resolved
lib/Map/RegionProviderTs.ts Outdated Show resolved Hide resolved
lib/Map/RegionProviderTs.ts Outdated Show resolved Hide resolved
lib/Map/RegionProviderTs.ts Outdated Show resolved Hide resolved
@nf-s nf-s merged commit 763ec77 into next Jan 28, 2021
@nf-s nf-s deleted the region-mapping-replacement branch January 28, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeyboardSounds KeyboardSounds KeyboardSounds approved these changes

Assignees

@KeyboardSounds KeyboardSounds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nf-s @KeyboardSounds