Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altered hashivault_list.py to use the hvac list_secrets method #164

Merged
merged 1 commit into from Oct 13, 2019

Conversation

@jasonneurohr
Copy link
Contributor

jasonneurohr commented Oct 4, 2019

I updated the hashivault_list.py to utilise client.secrets.kv.v2.list_secrets and client.secrets.kv.v1.list_secrets methods and permit specifying the version and mount point.

With the current version, we had to modify several roles to account for the metadata/ in the path when transitioning to version 2 of the Vault KV secret engine.

This version removes the need to account for metadata/ in the Ansible role allowing a more seamless transition from version 1 to version 2 of the Vault KV.

I included some logic to ensure it won't break existing roles that use metadata/.

Tests also updated to test against both version 1 and version 2 of the KV.

Copy link
Contributor

drewmullen left a comment

👏
LGTM!

@TerryHowe TerryHowe merged commit d3cd931 into TerryHowe:master Oct 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TerryHowe

This comment has been minimized.

Copy link
Owner

TerryHowe commented Oct 13, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.