New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to declare plan in `done_testing` #108

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@yanick
Contributor

yanick commented Dec 17, 2016

For #96

I'm not too sure how the testsuite works, so I didn't add any test. But trying test files like

use Test2::Bundle::Extended;

pass $_ for 1..3;

done_testing(4);

seems to indicate the minimalistic patch works.

@exodist

This comment has been minimized.

Show comment
Hide comment
@exodist

exodist Dec 17, 2016

Member

I don't want this to be part of Basic.pm. I would be fine with making it work in Test2::Bundle::More, but I intentionally did not add this feature for Test2::Bundle::Extended and Test2::Tools::Basic. I want done_testing() to take no args in case a toolmaker wants to add args in their own toolsets.

Member

exodist commented Dec 17, 2016

I don't want this to be part of Basic.pm. I would be fine with making it work in Test2::Bundle::More, but I intentionally did not add this feature for Test2::Bundle::Extended and Test2::Tools::Basic. I want done_testing() to take no args in case a toolmaker wants to add args in their own toolsets.

@yanick

This comment has been minimized.

Show comment
Hide comment
@yanick

yanick Dec 17, 2016

Contributor

Aaah... Gotcha. I was trailing the issues for one I could do for the CPAN Challenge of December, and it seemed an easy-enough one. :-)

Contributor

yanick commented Dec 17, 2016

Aaah... Gotcha. I was trailing the issues for one I could do for the CPAN Challenge of December, and it seemed an easy-enough one. :-)

@exodist

This comment has been minimized.

Show comment
Hide comment
@exodist

exodist Dec 18, 2016

Member

should be easy enough to make the done_testing in Test2::Bundle::More accept a p[lan if you want to work on that.

Member

exodist commented Dec 18, 2016

should be easy enough to make the done_testing in Test2::Bundle::More accept a p[lan if you want to work on that.

@exodist exodist closed this Dec 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment