Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

What does ok(0)->skip do? ok(0)->skip->todo? ok(0)->todo->skip? #8

Closed
schwern opened this Issue · 1 comment

1 participant

@schwern
Owner
  • GC-ID: 41
  • GC-Labels: Type-Enhancement, Priority-High, Milestone-Test-Builder2
  • GC-Status: Accepted
  • GC-Attachments: No

The concept of "todo and skip" is problematic. It's also technically
non-standard TAP.

ok(1)->skip->todo;            # ok 1 # SKIP TODO
ok(1)->skip("reason1")->todo("reason2")  # which reason wins?
ok(0)->skip;                  # a failing skip?
ok(0)->todo->skip;            # not ok 1 # SKIP TODO
ok(0)->skip->todo;            # ???

And in order to save all that state requires nonsense states like
"skip_fail" so that ok(0)->skip->todo works. See the logic in Result->skip
and Result->todo to see the problem.

Instead, I think we need just one method to declare it.

ok(0)->todo_skip;

@schwern
Owner

The way results work has been reengineered since this was written. It may be rewritten again, but this doesn't make much sense as written.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.